Repository navigation
Update impacket - #1164
Merged
Merged
Update impacket#1164
Conversation
NeffIsBack
requested review from
Marshall-Hallenbeck,
mpgn and
zblurx
as code owners
March 19, 2026 12:02
|
It looks like the PR template may not have been filled out. The following sections appear to be missing:
Please edit your PR description to include them. The template helps reviewers understand and test your changes. Thanks! |
mpgn
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the PR #1098 merged in yesterday, the
add-computermodule now uses impackets LDAP for updating/adding computers. However, this requires an update of impacket to the latest version which wasn't done in the PR, leading to a crash in current poetry installations. This PR simply updates the lock file to update impacket.Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
poetry installand thenpoetry run nxc smb -LScreenshots (if appropriate):