Skip to content

Update impacket - #1164

Merged
NeffIsBack merged 1 commit into
mainfrom
neff-fix-dependencies
Mar 19, 2026
Merged

NeffIsBack merged 1 commit into
mainfrom
neff-fix-dependencies

Conversation

@NeffIsBack

Copy link
Copy Markdown
Member

Description

With the PR #1098 merged in yesterday, the add-computer module now uses impackets LDAP for updating/adding computers. However, this requires an update of impacket to the latest version which wasn't done in the PR, leading to a crash in current poetry installations. This PR simply updates the lock file to update impacket.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

poetry install and then poetry run nxc smb -L

Screenshots (if appropriate):

image

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Mar 19, 2026
@github-actions

Copy link
Copy Markdown

It looks like the PR template may not have been filled out. The following sections appear to be missing:

  • Checklist

Please edit your PR description to include them. The template helps reviewers understand and test your changes. Thanks!

@NeffIsBack
NeffIsBack merged commit 9d65d3c into main Mar 19, 2026
11 checks passed
@NeffIsBack
NeffIsBack deleted the neff-fix-dependencies branch March 19, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants