update broken tests due to single-column PARTITION BY / ORDER BY change in latest CH#4298
Open
jgao54 wants to merge 1 commit into
Open
update broken tests due to single-column PARTITION BY / ORDER BY change in latest CH#4298jgao54 wants to merge 1 commit into
jgao54 wants to merge 1 commit into
Conversation
Contributor
🔄 Flaky Test DetectedAnalysis: All four failures are ✅ Automatically retrying the workflow |
Contributor
❌ Test FailureAnalysis: All 4 Test_NullEngine variants fail deterministically: a null row is inserted at the source (NumRecords=1) but never arrives in ClickHouse (NumRecords=0 after 217–249s of polling), indicating a real regression where null inserts are dropped before reaching the ClickHouse destination. |
Contributor
Author
|
Well, this fixes one of the two issues. |
jgao54
changed the title
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix e2e test failures:
ClickHouse 26.5+ preserves the parens around single-column PARTITION BY / ORDER BY in system.tables; older versions unwrap them.