Skip to content

Adding PublisherId field - #7

Merged
PawResz merged 17 commits into
masterfrom
publidherId_field
Aug 10, 2026
Merged

PawResz merged 17 commits into
masterfrom
publidherId_field

Conversation

@PawResz

@PawResz PawResz commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@github-actions

github-actions Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/allegroBidAdapter.js (+1 error)

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to modules/allegroBidAdapter.js may need:
    • es.iterator.find
    • esnext.iterator.find

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@PawResz PawResz changed the title Mateusz Adapter's fix Adding PublisherId field Aug 4, 2026
@PawResz
PawResz marked this pull request as ready for review August 7, 2026 09:39
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

Comment thread modules/allegroBidAdapter.js Outdated
* @param {string} newKey The destination key name (e.g. '[com.google.doubleclick.site]').
*/
function moveExt(obj, newKey) {
export function moveExt(obj, newKey) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tests for moveExt are needed it's covered by other test cases. drop the tests cases and export here.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got comments form one of the bots about this, but we can try to go without it.

@PawResz
PawResz merged commit c735c77 into master Aug 10, 2026
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants