Repository navigation
Adding PublisherId field - #7
Conversation
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
|
This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named |
| * @param {string} newKey The destination key name (e.g. '[com.google.doubleclick.site]'). | ||
| */ | ||
| function moveExt(obj, newKey) { | ||
| export function moveExt(obj, newKey) { |
There was a problem hiding this comment.
I don't think tests for moveExt are needed it's covered by other test cases. drop the tests cases and export here.
There was a problem hiding this comment.
I got comments form one of the bots about this, but we can try to go without it.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information