fix(settings): make launch-at-login reflect actual system state#14
Merged
Conversation
The toggle used @AppStorage as its source of truth, so it could disagree with macOS Login Items. If register() failed or the OS put the app in .requiresApproval, the UI showed it as on regardless. Errors were print()ed, which goes nowhere because AudioType is LSUIElement. - Source of truth is now SMAppService.mainApp.status. The toggle reads .enabled, refreshes on appear and when the app becomes active. - Failures surface inline (red caption), matching the API key fields. - .requiresApproval shows a hint and an 'Open Login Items' button that jumps straight to the right System Settings panel. - Drop the misleading UserDefaults key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Launch at Login toggle used
@AppStorageas its source of truth, so it could disagree with what macOS Login Items actually said. IfSMAppService.register()failed or the OS put the app in.requiresApproval, the toggle still showed "on". Errors went toprint(), which is invisible because AudioType is anLSUIElement(no console attached).Changes
SMAppService.mainApp.status. Toggle reads.enabled; refreshes on.onAppearand onNSApplication.didBecomeActiveNotification(so toggling the setting in System Settings is picked up)..requiresApprovalshows a hint plus an "Open Login Items" button that deep-links to the correct System Settings panel.launchAtLoginUserDefaults key.Verification
swift buildclean.