Add explicit Fedora Atomic install methods and harden release installs - #1
Merged
Conversation
…nstall Harden Atomic Topgrade installs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Fedora Atomic / rpm-ostree install flow so users can choose between two supported Topgrade ownership models:
COPR / rpm-ostree
lilay/topgradeCOPR repository withincludepkgs=topgradeOfficial upstream binary
~/.local/bin/topgradeThe goal is to avoid presenting either path as universally “right” or “wrong”. Instead, the installer documents and supports both trust/ownership models clearly.
What changed
Added Atomic install method selection:
--install-method=binary--install-method=coprAdded aliases:
--binary--coprInteractive Fedora Atomic sessions now prompt when no method is specified.
Non-interactive Fedora Atomic sessions default to the binary method.
COPR / rpm-ostree remains supported for users who want package-manager integration.
The COPR repo file is restricted with:
includepkgs=topgradeThe upstream binary install path now:
topgrade --versionExisting config handling performs small policy repairs with backups:
no_self_update = truerpm_ostree = trueUpdated English and German README documentation with a comparison of the two Fedora Atomic methods.
Why
The COPR security/trust scope is narrower than a blanket “trust all of COPR”: enabling
lilay/topgradetrusts that specific COPR project, not unrelated COPR repositories.However, the upstream binary path is still useful for users who prefer not to add a persistent third-party RPM repository or layer Topgrade into an Atomic host.
This PR makes that tradeoff explicit:
Validation
bash -n install-topgrade.sh--severity=errorv17.9.0~/.local/bin/topgradetopgrade --versionreturned the expected versionrpm_ostree = trueincludepkgs=topgraderpm_ostree = trueno_self_update = truegit diff --check