refactor(magic-rewrite): prepare V1 for review#1256
Closed
cha1latte wants to merge 3 commits into
Closed
Conversation
Slim V1 of Magic Rewrite: AI-assisted text rewriting for lorebook, character, and persona editors. - POST /api/magic-rewrite/generate endpoint using existing default agent connection fallback - MagicRewritePanel: instruction textarea, word-level diff view, HelpTooltip noting agent connection usage - Integrated into ExpandedTextarea and LorebookFormFields modals with Apply/Back flow Addresses Pasta-Devs#1183 (scoped V1 per maintainer feedback).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
closing accidentally had this on staging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Refs #1183
Refs #1238
Why this change
PR #1238 contains the Magic Rewrite V1 feature, but the branch was based on
mainwhile targetingstaging, which pulls unrelated tracker/composer/changelog work into the review diff.This cleanup branch replays the Magic Rewrite work onto
stagingand separates the first server/client seams so the feature is easier to review and refactor without changing the intended V1 behavior.What changed
upstream/staging.packages/server/src/services/magic-rewrite/magic-rewrite.service.ts.packages/server/src/routes/magic-rewrite.routes.tsfocused on request validation and HTTP response handling.packages/client/src/hooks/use-magic-rewrite.ts.Validation
pnpm checkpasses locallyCONTRIBUTING.mdManual verification notes
pnpm checksuccessfully inC:\tmp\marinara-pr-1238.git diff --checksuccessfully.Generate Rewritewith a configured text LLM connection.Docs and release impact
UI evidence (if applicable)
Character editor Magic Rewrite panel:
Lorebook entry Magic Rewrite panel: