fix(editor): allow browser spell check in markdown editor#68
fix(editor): allow browser spell check in markdown editor#68PascalRepond merged 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughNarrowed HTMX-driven per-field validation in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/core/forms.py`:
- Line 59: The MDEWidget for the "review" field currently uses
inputStyle="contenteditable" which can desync content from the underlying
textarea before HTMX validation or form submission; change the field definition
in the form (the "review" entry that instantiates MDEWidget) to remove
inputStyle="contenteditable" so it uses the default textarea (i.e.,
MDEWidget(options={"nativeSpellcheck": True})); if you must keep
contenteditable, instead add "review" to the form's HTMX exclusion list in
__init__ (same place as "cover" and "contributors") and add explicit sync logic
in media_edit.js to copy the contenteditable editor back into the textarea
before any HTMX request or on form submit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0d0190b8-d181-41d2-a9b3-88150f28d667
⛔ Files ignored due to path filters (2)
src/theme/static_src/package-lock.jsonis excluded by!**/package-lock.jsonuv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
src/core/forms.py
Keep contenteditable mode for Firefox spellcheck support but exclude the review field from HTMX validation to avoid content desync. Refactor validation to disable fields where dynamic validation is not needed, and using an explicit allowlist instead of a growing denylist.
Also update dependencies.