Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR tidies up package dependencies by moving ggraph into the Imports section of the DESCRIPTION file and removes an unused Depends entry. It also upgrades the GitHub Actions artifact upload action to v4 and parameterizes the artifact name.
- Moved
ggraphfromDependstoImportsin DESCRIPTION - Bumped
actions/upload-artifactfrom v3 to v4 and updated artifact naming in test-coverage workflow
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DESCRIPTION | Added ggraph to Imports list; removed the empty Depends: block |
| .github/workflows/test-coverage.yaml | Upgraded upload-artifact action to v4; parameterized artifact name |
Comments suppressed due to low confidence (1)
.github/workflows/test-coverage.yaml:49
- The artifact name uses
runner.temp, which is a full filesystem path and may include invalid characters (e.g., slashes). Consider using a safer identifier, such asgithub.run_idor{{ github.run_number }}, to avoid naming issues.
name: coverage-test-failures-${{ runner.temp }}
|
Excellent, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34