Skip to content

Comments

Move data.table to Imports#35

Merged
PascalCrepey merged 3 commits intomasterfrom
import_datatable
Jul 8, 2025
Merged

Move data.table to Imports#35
PascalCrepey merged 3 commits intomasterfrom
import_datatable

Conversation

@PascalCrepey
Copy link
Owner

Fixes #34

@PascalCrepey PascalCrepey self-assigned this Jul 8, 2025
@PascalCrepey PascalCrepey requested a review from Copilot July 8, 2025 22:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tidies up package dependencies by moving ggraph into the Imports section of the DESCRIPTION file and removes an unused Depends entry. It also upgrades the GitHub Actions artifact upload action to v4 and parameterizes the artifact name.

  • Moved ggraph from Depends to Imports in DESCRIPTION
  • Bumped actions/upload-artifact from v3 to v4 and updated artifact naming in test-coverage workflow

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
DESCRIPTION Added ggraph to Imports list; removed the empty Depends: block
.github/workflows/test-coverage.yaml Upgraded upload-artifact action to v4; parameterized artifact name
Comments suppressed due to low confidence (1)

.github/workflows/test-coverage.yaml:49

  • The artifact name uses runner.temp, which is a full filesystem path and may include invalid characters (e.g., slashes). Consider using a safer identifier, such as github.run_id or {{ github.run_number }}, to avoid naming issues.
          name: coverage-test-failures-${{ runner.temp }}

@PascalCrepey PascalCrepey merged commit 19291b0 into master Jul 8, 2025
7 checks passed
@PascalCrepey PascalCrepey deleted the import_datatable branch July 8, 2025 23:30
@MichaelChirico
Copy link

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move data.table to Imports

2 participants