Skip to content

Add the stub for tippy to the Throughput report tests#3061

Merged
tamararivera merged 2 commits into
masterfrom
add-tippy
Jul 15, 2026
Merged

Add the stub for tippy to the Throughput report tests#3061
tamararivera merged 2 commits into
masterfrom
add-tippy

Conversation

@tamararivera

@tamararivera tamararivera commented Jul 10, 2026

Copy link
Copy Markdown
Member

This should prevent some of the noise when running the component test for the Throughput report, as now we get a lot of warnings because this is missing.

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

@tamararivera tamararivera requested a review from cquirosj July 10, 2026 16:55
@tamararivera tamararivera self-assigned this Jul 10, 2026
@ngallegos ngallegos mentioned this pull request Jul 13, 2026
5 tasks

@ngallegos ngallegos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a global tippy stub so future tests don't have to add it?

This suggestion PR does that and removes test-specific stubs that generate duplicate warnings when the global stub is introduced:

* Remove tippy directive warnings globally

* Missed some duplicate tippy stubs

* Revert "Add the stub for tippy to the Throughputreport tests"

This reverts commit 58beaa2.

* Linter doesn't like the comment
@tamararivera

Copy link
Copy Markdown
Member Author

Now there is a lot less noise on the test output 🎉

@tamararivera tamararivera merged commit c97d8e2 into master Jul 15, 2026
5 checks passed
@tamararivera tamararivera deleted the add-tippy branch July 15, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants