Skip to content

My permissions page always shows even if authorization is disabled #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBZA merged 1 commit into from
Jul 9, 2026
Merged

My permissions page always shows even if authorization is disabled #3060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/Frontend/src/components/configuration/UserPermissions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,15 @@ export const groups: ApplicationCapabilityGroup[] = [

<script setup lang="ts">
import { computed } from "vue";
import { storeToRefs } from "pinia";
import { faCheck, faXmark } from "@fortawesome/free-solid-svg-icons";
import FAIcon from "@/components/FAIcon.vue";
import ConditionalRender from "@/components/ConditionalRender.vue";
import { useAllowedRoutes } from "@/composables/useAllowedRoutes";
import { useAuthStore } from "@/stores/AuthStore";

const { canCall, supported, roles } = useAllowedRoutes();
const { authorizationEnabled } = storeToRefs(useAuthStore());

const rows = computed(() =>
groups.map((g) => ({
Expand Down Expand Up @@ -130,7 +133,21 @@ const rows = computed(() =>
</div>
</template>

<table class="permissions-table">
<div v-if="authorizationEnabled === false" class="container not-supported">
<div class="row">
<div class="col-sm-12">
<div class="text-center message">
<p>Role-based access control is not enabled.</p>
<p>Control who can see and do what in ServicePulse. Role-based authorization lets you restrict failed message retries, endpoint management, and other sensitive actions to the right people.</p>
<div>
<a class="btn btn-default btn-primary" href="https://docs.particular.net/servicecontrol/security/configuration/authorization" target="_blank">Learn how to enable authorization</a>

@ramonsmits ramonsmits Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBZA shouldn't this be a search link or have been been actually linking to specific docs in SP before?

@WilliamBZA WilliamBZA Jul 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got direct links in other places too

</div>
</div>
</div>
</div>
</div>

<table v-else class="permissions-table">
<thead>
<tr>
<th scope="col" class="area-col">Area</th>
Expand Down
6 changes: 6 additions & 0 deletions src/Frontend/src/stores/AuthStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import serviceControlClient from "@/components/serviceControlClient";

interface AuthConfigResponse {
enabled: boolean;
// Absent on ServiceControl versions older than the one that introduced this field.
role_based_authorization_enabled?: boolean;
client_id: string;
authority: string;
api_scopes: string;
Expand All @@ -21,6 +23,8 @@ export const useAuthStore = defineStore("auth", () => {
const authError = ref<string | null>(null);
const authConfig = ref<AuthConfig | null>(null);
const authEnabled = ref(false);
// undefined means ServiceControl didn't report this field (older version) — treat as enabled.
const authorizationEnabled = ref<boolean | undefined>(undefined);
const loading = ref(true);

async function refresh() {
Expand All @@ -29,6 +33,7 @@ export const useAuthStore = defineStore("auth", () => {
const config = await getAuthConfig();
if (config) {
authEnabled.value = config.enabled;
authorizationEnabled.value = config.role_based_authorization_enabled;
authConfig.value = config.enabled ? transformToAuthConfig(config) : null;
}
} finally {
Expand Down Expand Up @@ -108,6 +113,7 @@ export const useAuthStore = defineStore("auth", () => {
authError,
authConfig,
authEnabled,
authorizationEnabled,
loading,
refresh,
setToken,
Expand Down
3 changes: 3 additions & 0 deletions src/Frontend/test/preconditions/authentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as precondition from ".";
*/
export interface AuthConfigResponse {
enabled: boolean;
role_based_authorization_enabled: boolean;
client_id: string;
authority: string;
api_scopes: string;
Expand All @@ -19,6 +20,7 @@ export interface AuthConfigResponse {
*/
export const authDisabledConfig: AuthConfigResponse = {
enabled: false,
role_based_authorization_enabled: false,
client_id: "",
authority: "",
api_scopes: "[]",
Expand All @@ -31,6 +33,7 @@ export const authDisabledConfig: AuthConfigResponse = {
*/
export const authEnabledConfig: AuthConfigResponse = {
enabled: true,
role_based_authorization_enabled: true,
client_id: "servicepulse-test",
authority: "https://login.microsoftonline.com/test-tenant-id/v2.0",
api_scopes: '["api://servicecontrol/access_as_user"]',
Expand Down