Repository navigation
Fix engine lifecycle cleanup and host API boundaries - #36
Draft
ParthJadhav wants to merge 1 commit into
Draft
ParthJadhav wants to merge 1 commit into
ParthJadhav wants to merge 1 commit into
Conversation
Merged
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom-tool setup and host callback failures could leak an engine, interrupt cleanup, or leave subscribers stale. Make mounting transactional across vanilla, React, Vue, and custom elements; isolate observer failures; and finish disposal and gesture/audio cleanup when custom tools throw.
Reject nonfinite rate-limiter and history inputs, reject overlapping scripted strikes, and preserve state after invalid elapsed times. Add 20 regression tests, API documentation, and a patch changeset.
Verification
bun run checkpasses: 432 tests, type checking, lint, coverage, builds, and package checks.bun scripts/browser-test.mjs.bun run docs:buildand the hosted docs drift/link checks pass.Notes
The Node 24 browser-harness runs lost their Chrome connection before reporting checks. The same unmodified suite completed successfully under Bun with Google Chrome. The memory harness completed under Node.