Repository navigation
Require React Doctor 100 in local verification - #35
ParthJadhav wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 363b775fa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const root = fileURLToPath(new URL("../", import.meta.url)); | ||
| const result = spawnSync( | ||
| "npx", | ||
| ["--yes", "react-doctor@latest", ".", "--yes", "--scope", "full", "--json"], |
There was a problem hiding this comment.
Pin react-doctor to a reviewed, lockfile-controlled version instead of executing @latest. The publish path runs bun run release, which invokes bun run check and this script from the privileged Changesets step in .github/workflows/release.yml; that step exposes a write-capable GITHUB_TOKEN and has id-token: write. A compromised or newly malicious registry release could therefore execute arbitrary code with release credentials, while even a benign incompatible update can unexpectedly block publishing.
Useful? React with 👍 / 👎.
Require a complete React Doctor score of 100 in
bun run check, with a standalonebun run doctorcommand and a cached JSON report. Missing, partial, or failed scans fail verification.Initialize the headless React controller through lazy state, use a structured benchmark snapshot clone and a Set for fixture membership checks, and run independent Chrome setup operations together. Keep the browser readiness probe boolean so CDP does not serialize capture pixel buffers.
Validation:
bun run check: 413 tests passed; complete React Doctor 100/100; type, lint, coverage, build, and package checks passed.bun run docs:build: passed.