Repository navigation
feat(desktop): a first macOS test build comes as a universal dmg from the installer workflow - #361
Merged
Merged
Conversation
… the installer workflow The installer workflow gets a macOS job that builds an ad hoc signed universal dmg, keeps it as an artifact and checks architectures, signature, both credential stores and that the app survives its start. On macOS PartBuddy finds SolidCraft in its app bundle and Claude Code in the Homebrew folders, because an app started from the Finder does not get the shell's PATH. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… the app ends Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…n empty merged one Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…not install Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
electron-builder.yml:mactarget (universal dmg), icon from a new 1024 px render of the app icon (tools/brand/build.mjs), ad hoc signature, the credential store for both darwin architectures.dist:macscript;distanddist:dirstay on--win.installer.yml: second job onmacos-15that builds the dmg, keeps it as an artifact and checks it (universal binary, ad hoc signature, bothkeyring.darwin-*.node, the app stays running for 25 s)./Applications/SolidCraft.appand~/Applications; the file dialog takes the.appbundle.solidcraft-clilies beside the program inside the bundle (seen insolidcraft-0.40.1-macos-universal.dmg), so the separate CLI zip is not needed./opt/homebrew/binand/usr/local/bin, because an app started from the Finder does not get the shell's PATH.Not verified
Nobody on the team has a Mac. Beyond the checks of the macOS job nothing was run on macOS: no SolidCraft start, no sign-in, no 3D view, no E2E. The build is not notarized; Gatekeeper asks once.
Tests
eslint, type check and vitest (
discovery,agent,engineChoice) locally; the Windows build is unchanged.🤖 Generated with Claude Code