fix(peers): phase 1 polish — deferred review items#130
Merged
Conversation
…rchiveTask test, gitignore - ws-transport: validate Array.isArray(ops) on incoming OPS frame; log and return on malformed payload instead of throwing during iteration - service-registry: capture WsTransport handle; expose disposePeerTransport for app-quit cleanup instead of fire-and-forget - lifecycle: invoke disposePeerTransport on before-quit - progress-service-replicates.test: add archiveTask coverage (update op with status=archived + archived_at) - .gitignore: exclude playwright-report/ and test-results/ artifacts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the three minor code-review items deferred from PR #129:
ws-transport.ts— malformedOPSframes now log and return rather than throwing during iteration.service-registrynow captures theWsTransporthandle and exposesdisposePeerTransport;lifecycle.before-quitawaits it so the server socket + incoming client sockets close cleanly on app quit.progress-service-replicates.test.ts— verifies the op carriesstatus='archived'+archived_at+updated_atin snake_case.Also:
.gitignoregetsplaywright-report/andtest-results/(local artifacts).Test plan