Skip to content

Add accessible names to decorative SVG icons #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add accessible names to decorative SVG icons #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/IconButton.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const { icon, label, href, className } = Astro.props;
class={`inline-block h-min w-min rounded-full p-2 leading-0 transition-colors hover:bg-gray-800/20 dark:hover:bg-gray-400/20 ${className}`}
aria-label={label}
>
<Icon name={icon} class="size-6 text-gray-700 dark:text-gray-300" />
<Icon name={icon} class="size-6 text-gray-700 dark:text-gray-300" aria-hidden="true" />
</a>
) : (
<button class={`h-min w-min rounded-full p-2 transition-colors hover:bg-gray-800/20 ${className}`} aria-label={label}>
Expand Down
4 changes: 2 additions & 2 deletions src/components/layout/NavBar.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ import LogoMarkerLight from "@/assets/brand/logo-marker-light.svg";
</NavDropDown>
<NavLink href="https://hangar.papermc.io/" target="_blank" className="inline-flex items-center">
Plugins
<Icon name="icons/heroicons/arrow-top-right-on-square" class="ml-1 size-4 align-sub" />
<Icon name="icons/heroicons/arrow-top-right-on-square" class="ml-1 size-4 align-sub" aria-hidden="true" />
</NavLink>
<NavLink href="https://docs.papermc.io/" target="_blank" className="inline-flex items-center">
Docs
<Icon name="icons/heroicons/arrow-top-right-on-square" class="ml-1 size-4 align-sub" />
<Icon name="icons/heroicons/arrow-top-right-on-square" class="ml-1 size-4 align-sub" aria-hidden="true" />
</NavLink>
<NavLink href="/news">News</NavLink>
<NavLink href="/team">Team</NavLink>
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/NavDropDown.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const { label, className } = Astro.props;
data-trigger
>
{label}
<Icon name="icons/heroicons/chevron-down" class="h-4 w-4 fill-gray-700 dark:fill-gray-300" />
<Icon name="icons/heroicons/chevron-down" class="h-4 w-4 fill-gray-700 dark:fill-gray-300" aria-hidden="true" />
</span>

<ul
Expand Down