Skip to content

Fix for new UI of Safari 12 - #8

Open
jordn wants to merge 1 commit into
PaperKup:masterfrom
jordn:safari12fix
Open

Fix for new UI of Safari 12#8
jordn wants to merge 1 commit into
PaperKup:masterfrom
jordn:safari12fix

Conversation

@jordn

@jordn jordn commented Sep 25, 2018

Copy link
Copy Markdown

The UI elements have moved around in Safari 12 from Safari 11, resulting in this not working, with
errors along the lines of:
"System Events got an error: Can’t set value of missing value
to "\X.com\" from value of missing value"

This updates the script for traversing the new UI elements.

The UI elements have moved around in Safari 12 from Safari 11.
Resuting in errors along the lines of:
"System Events got an error: Can’t set value of missing value
to X.com from value of missing value", stopping this from working.

This updates the script for traversing the new UI elements.
@adussaq

adussaq commented Oct 1, 2018

Copy link
Copy Markdown

I agree with this fix, although there is still an issue, the passwords when exported from Chrome have four columns. So lines 31-33 need to be incremented to 2,3,4 from 1,2,3.

@noahbjohnson

Copy link
Copy Markdown

I agree with this fix, although there is still an issue, the passwords when exported from Chrome have four columns. So lines 31-33 need to be incremented to 2,3,4 from 1,2,3.

Not sure this is a valid issue with this code. The readme states the expected csv format, it's up to the user to get the password file in the correct format prior to importing.

@LeftDelirious LeftDelirious left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the problem. Thanks!

@ianmacartney

Copy link
Copy Markdown

@adussaq I addressed your concern in #9 which also updates the readme and dummy file to address @noahbjohnson's concern. since the common case is importing chrome's csv, I don't see a reason to ask people to do unnecessary work. the minority with the other format can do the work, or we can adjust the script to accept either depending on how many values there are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants