Skip to content

fix(wiki): prefix gacha iframe src with Astro base path #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PanQiWei merged 1 commit into from
Apr 27, 2026
Merged

fix(wiki): prefix gacha iframe src with Astro base path #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions site/src/components/WikiAtlas.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

import type { Locale } from "~/i18n/strings";
import { wikiEntry } from "~/lib/urls";
import { BASE, wikiEntry } from "~/lib/urls";
import manifest from "~/content/wiki/_manifest.json";
import { getCollection } from "astro:content";
import OneShotCard from "~/components/card/OneShotCard.astro";
Expand Down Expand Up @@ -167,7 +167,7 @@ const cardEntries = [...byKind.concepts, ...byKind.entities].sort((a, b) => a.sl
</section>

{/* ── Gacha overlay (hidden until 抽卡 clicked) ───────────────── */}
<div class="gacha" role="dialog" aria-modal="true" hidden data-lang={locale}>
<div class="gacha" role="dialog" aria-modal="true" hidden data-lang={locale} data-base={BASE}>
<button class="gacha__backdrop" aria-label={locale === "zh" ? "关闭" : "close"}></button>
<div class="gacha__card">
<iframe class="gacha__frame" title={locale === "zh" ? "卡片" : "card"} src="about:blank"></iframe>
Expand Down Expand Up @@ -257,6 +257,11 @@ const cardEntries = [...byKind.concepts, ...byKind.entities].sort((a, b) => a.sl
const gachaAgain = gacha.querySelector<HTMLButtonElement>(".gacha__again")!;
const gachaBackdrop = gacha.querySelector<HTMLElement>(".gacha__backdrop")!;
const lang = gacha.dataset.lang ?? "zh";
// Astro `base` (e.g. "/advanced-agentic-dev-patterns" on GitHub Pages,
// "" on local dev). Without this prefix the iframe would request
// `/card-fragment/...` against the domain root and Pages would serve
// its default 404 page inside the modal.
const base = gacha.dataset.base ?? "";

function syncFrameTheme() {
if (!gachaFrame.contentDocument) return;
Expand All @@ -273,7 +278,7 @@ const cardEntries = [...byKind.concepts, ...byKind.entities].sort((a, b) => a.sl
const pick = candidates[Math.floor(Math.random() * candidates.length)];
gachaCard.dataset.kind = pick.kind;
gachaGo.href = pick.href;
const nextSrc = `/card-fragment/${lang}/${pick.kind}/${pick.slug}`;
const nextSrc = `${base}/card-fragment/${lang}/${pick.kind}/${pick.slug}`;
gachaFrame.src = nextSrc;
gachaFrame.addEventListener("load", syncFrameTheme, { once: true });
gachaCard.classList.remove("is-flipping");
Expand Down
Loading