Skip to content

build(deps): patch shell-quote and seroval advisories - #48

Merged
PanAchy merged 2 commits into
mainfrom
dependabot/npm_and_yarn/shell-quote-1.12.0
Oct 15, 2026
Merged

PanAchy merged 2 commits into
mainfrom
dependabot/npm_and_yarn/shell-quote-1.12.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix both open dependency advisories without changing the OpenCode/Effect pins or removing the UI integration.

  • Keep Dependabot's shell-quote update from 1.10.0 to 1.12.0 for GHSA-pqg4-j6r4-53mv.
  • Resolve Solid's seroval from 1.5.6 to 1.6.9 for GHSA-p6vx-979v-rg4c, using an exact override scoped to solid-js@1.9.12.
  • Add credential-free behavior tests for both advisory cases, ordinary Seroval Promise/cyclic-data round trips, and Solid async rendering/hydration with the patched serializer.

The override is needed because Solid 1.9.12 requires seroval ~1.5.0, excluding every patched version. OpenTUI pins Solid exactly to 1.9.12, including in its latest release, so bumping Solid alone would violate that peer contract. The scoped override leaves Solid, OpenTUI, OpenCode 2.0.27, Effect 4.0.1, and every other dependency unchanged.

This fixes this repository's dependency resolution. Root npm overrides do not propagate into consumers' separate OpenCode installations. Jevvy's permission code does not invoke Seroval's affected fromJSON() path, and neither vulnerable package is bundled into its hook. This PR does not claim to patch every host's UI dependency graph.

Verification

  • The thenable regression fails on Seroval 1.5.6 because the callback is invoked, and passes on 1.6.9 because deserialization rejects it without invocation. No shell payload or remote request is executed.
  • All four focused behavior/compatibility tests pass.
  • Full npm run check passes: typecheck, lint, 378 tests, and build. No lint suppressions or weakened rules.
  • npm audit --json reports zero vulnerabilities in this PR's installed dependency tree, including zero critical findings.
  • npm ls confirms only patched shell-quote@1.12.0 and seroval@1.6.9, with the existing Seroval plugins deduplicating to 1.6.9.
  • Independent lockfile comparison confirms that only the shell-quote and seroval package entries differ from main. All Effect/OpenCode versions are unchanged.
  • changeset status and git diff --check pass. No consumer package manifest, source API, question, threshold, model, or release version changes.
  • Sequential npm run smoke passed: packed package and all eleven setup scenarios, OpenCode 2.0.27 real shell review, Claude host loading, and native controls. These smokes made no real provider calls.
  • Repacked public tarball is byte-identical to the previously E2E-verified candidate: SHA-256 ec219b9bbefee65f8e8d7845bb379872f2d066c1330ff71f80186fa7c8b84058, 602319 bytes. This correction changes the private repository dependency graph, not the shipped runtime artifact.
  • GitHub CI run 38668620667 passed on 9f60366: Check, both host smokes, and all six Linux/Windows/macOS x64/arm64 package jobs. The second event-triggered run is tracked separately.

Release scope

This is private development/optional-UI dependency maintenance, so no product version changeset is added. Release PR #49 remains untouched and unmerged. The user has more work planned before another release.

@dependabot
dependabot Bot requested a review from PanAchy as a code owner October 15, 2026 01:18
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 15, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/shell-quote-1.12.0 branch 3 times, most recently from f3b6104 to 6c9fb61 Compare October 15, 2026 01:48
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.10.0 to 1.12.0.
- [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md)
- [Commits](ljharb/shell-quote@v1.10.0...v1.12.0)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-version: 1.12.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/shell-quote-1.12.0 branch from 6c9fb61 to 6a1838a Compare October 15, 2026 01:52
Solid 1.9.12 excludes patched seroval versions while OpenTUI pins that Solid release exactly. Scope a seroval 1.6.9 override to that existing Solid version instead of widening peer contracts or changing OpenCode and Effect pins. Preserve the shell-quote security update and cover both advisory behaviors plus serializer compatibility. Root overrides apply only to this repository, not consumer host dependency graphs.
@PanAchy PanAchy added the full-package-smoke Run the package smoke matrix on Linux, Windows, and macOS x64/arm64 label Oct 15, 2026
@PanAchy PanAchy changed the title build(deps-dev): bump shell-quote from 1.10.0 to 1.12.0 build(deps): patch shell-quote and seroval advisories Oct 15, 2026
@PanAchy
PanAchy added this pull request to stack #52 October 15, 2026 02:02
@PanAchy PanAchy removed the full-package-smoke Run the package smoke matrix on Linux, Windows, and macOS x64/arm64 label Oct 15, 2026
@PanAchy
PanAchy merged commit d8dc523 into main Oct 15, 2026
18 checks passed
@PanAchy
PanAchy deleted the dependabot/npm_and_yarn/shell-quote-1.12.0 branch October 15, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant