Repository navigation
fix: restore LEANN HTTP server OpenAPI and search body parsing - #2
Draft
Paltidor87 wants to merge 1 commit into
Draft
Paltidor87 wants to merge 1 commit into
Paltidor87 wants to merge 1 commit into
Conversation
Co-authored-by: Peggens <iamaltidor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes LEANN HTTP server schema/validation issues that broke both
/openapi.jsonandPOST /indexes/{index_name}/search.Changes
test_openapi_schema_loadsensures/openapi.jsonrenders successfully.test_search_endpoint_accepts_json_bodyensures plain JSON request bodies are accepted by the search route.packages/leann-core/src/leann/server.py:Bodyfrom FastAPI in lazy loader.body: dict[str, Any] = Body(...).SearchRequest(**body)inside the route handler.This removes the unresolved forward-ref/schema generation failure and restores normal request parsing.
Related Issues
Fixes #
Checklist
uv run pytest)ruff formatandruff check)pre-commit run --all-files)Verification performed
uv run pytest tests/test_http_server_api.py -qpasses.GET /healthreturns{"status":"ok"}GET /indexesreturns indexed entriesGET /openapi.jsonreturns valid schema including/indexes/{index_name}/searchPOST /indexes/env-check/searchwith JSON body returns search results