feat: TUI mode with scroll, mouse, conversation rendering fixes#24
Open
PTFOPlayer wants to merge 1 commit into
Open
feat: TUI mode with scroll, mouse, conversation rendering fixes#24PTFOPlayer wants to merge 1 commit into
PTFOPlayer wants to merge 1 commit into
Conversation
Owner
PTFOPlayer
commented
Jun 5, 2026
- Add full TUI mode with conversation pane, input bar, status bar, sidebar
- Fix scroll: mouse scroll and PageUp/PageDown/Home/End now always go to conversation widget regardless of focus
- Fix mouse scroll: SGR mouse event parsing was broken (< prefix not stripped from parameter string, causing scroll events to be parsed as left-click)
- Fix conversation text overflow: text now wraps at conversation area width (area.x + area.width - 1) instead of full screen width, preventing overflow into sidebar area
- Fix conversation line height: now uses character-level wrapping matching actual screen rendering, preventing visual rows from being undercounted
- Fix scroll offset: changed from conversation-line units to visual-row units that account for text wrapping, so scrolling works correctly with long messages
- Fix partially-scrolled line rendering: added write_str_wrapped_skip_clipped to Screen that skips N visual rows before rendering, so lines scrolled off the top of the viewport don't re-render their full text
- ToolResult now renders all content lines (not just first), with background fill, line truncation, and a 20-line cap with truncation indicator
- ToolResult trims trailing blank lines from content
- Scrollbar column is reserved (1 column) so text doesn't overlap it
- Add thinking indicator: shows [thinking] with spinner during thinking phase, accumulates thinking text, transitions to 'Responding' label on first streaming text
- Widget trait render method changed from &self to &mut self
- All widget implementations updated accordingly
- Add full TUI mode with conversation pane, input bar, status bar, sidebar - Fix scroll: mouse scroll and PageUp/PageDown/Home/End now always go to conversation widget regardless of focus - Fix mouse scroll: SGR mouse event parsing was broken (< prefix not stripped from parameter string, causing scroll events to be parsed as left-click) - Fix conversation text overflow: text now wraps at conversation area width (area.x + area.width - 1) instead of full screen width, preventing overflow into sidebar area - Fix conversation line height: now uses character-level wrapping matching actual screen rendering, preventing visual rows from being undercounted - Fix scroll offset: changed from conversation-line units to visual-row units that account for text wrapping, so scrolling works correctly with long messages - Fix partially-scrolled line rendering: added write_str_wrapped_skip_clipped to Screen that skips N visual rows before rendering, so lines scrolled off the top of the viewport don't re-render their full text - ToolResult now renders all content lines (not just first), with background fill, line truncation, and a 20-line cap with truncation indicator - ToolResult trims trailing blank lines from content - Scrollbar column is reserved (1 column) so text doesn't overlap it - Add thinking indicator: shows [thinking] with spinner during thinking phase, accumulates thinking text, transitions to 'Responding' label on first streaming text - Widget trait render method changed from &self to &mut self - All widget implementations updated accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.