Skip to content

Use scikit-learn version 1.9.0 (rather than 1.8.0) #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinholmer merged 2 commits into from
Jul 13, 2026
Merged

Use scikit-learn version 1.9.0 (rather than 1.8.0) #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9d131
Revise setup.py wrt scikit-learn version
martinholmer Jul 12, 2026
f25791f
Upgrade scikit-learn from 1.8.0 to 1.9.0
martinholmer Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,13 @@ For Tax-Calculator results generated when using these TMD input files,
see [this
folder](https://github.com/PSLmodels/Tax-Calculator/tree/master/taxcalc/cli/input_data_tests).

The **current TMD version is 2.1.3**, which was released on July 2,
2026, and is the same as TMD version 2.1.2 except that at least Tax-Calculator
version 6.7.1 (instead of 6.7.0) is required to generate the TMD files.
This new Tax-Calculator version uses a more refined refundable
credit claiming logic, which causes minor changes in the TMD input
data files generated by this repo (even after some recalibration of
the TMD data generation logic). [Tax-Calculator pull request
3087](https://github.com/PSLmodels/Tax-Calculator/pull/3087) shows the
small differences in baseline policy results when using the new TMD
2.1.3 input data files (instead of the old 2.1.2 input data files
generated using Tax-Calculator version 6.7.0).
The **current TMD version is 2.1.4**, which was released on July 13,
2026, and is the same as TMD version 2.1.3 except that a new version
of `scikit-learn` (1.9.0), which fixed a bug in its weighted imputation
algorithm, is used (see #534 for details). Tax-Calculator version 6.7.1
or higher is required to generate the TMD files.

When using version 2.1.3 to generate **sub-national weights**, there
When using version 2.1.4 to generate **sub-national weights**, there
will be (presumably small) differences from the sub-national weights
generated using earlier versions; however, the sub-national weights
fingerprints have not yet been updated.
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

setup(
name="tmd",
version="2.1.3",
version="2.1.4",
packages=find_packages(),
python_requires=">=3.11,<3.14",
install_requires=[
"taxcalc>=6.7.1",
"numpy",
"pandas>=3.0.2",
"clarabel",
"scikit-learn==1.8.0",
"scikit-learn>=1.9.0",
"scipy",
"xlrd",
"openpyxl",
Expand Down
2 changes: 1 addition & 1 deletion tests/expected_tax_exp_2022_data
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
YR,KIND,EST= 2023 paytax 1428.8
YR,KIND,EST= 2023 paytax 1431.0
YR,KIND,EST= 2023 iitax 2332.1
YR,KIND,EST= 2023 ctc 129.6
YR,KIND,EST= 2023 eitc 66.9
Expand Down
Loading
Loading