Skip to content

Conversation

@SimonWahlin
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings July 3, 2025 08:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AzAuth dependency to v2.5.0 across module manifests, updates the changelog to reflect that bump and the new 0.2.0 release, and removes an old workaround in the Test-AzureToken function now that AzAuth fixes the aud claim.

  • Bump AzAuth to 2.5.0 in RequiredModules.psd1 and module manifest
  • Update CHANGELOG with an Unreleased entry and 0.2.0 release notes
  • Simplify Test-AzureToken by removing scope-based fallback logic

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
RequiredModules.psd1 Updated AzAuth version to 2.5.0
AzResourceGraph/AzResourceGraph.psd1 Updated AzAuth version to 2.5.0 in module manifest
AzResourceGraph/Private/Test-AzureToken.ps1 Removed legacy scope fallback when checking tokens
CHANGELOG.md Added Unreleased changelog and 0.2.0 release notes
Comments suppressed due to low confidence (2)

CHANGELOG.md:20

  • [nitpick] The entry 'Enhance token management' is vague and uses present tense. Consider rephrasing to 'Enhanced token management' and adding a brief detail about what was improved.
- Enhance token management

AzResourceGraph/Private/Test-AzureToken.ps1:50

  • Removing the fallback check for $Token.Scopes could break environments where AzAuth still emits tokens without a correct aud claim. Confirm that v2.5.0 always provides a valid aud or restore a fallback.
        $Resource -eq $Token.Claims['aud']

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Linux Test Results

 1 files  ±0  16 suites  ±0   4s ⏱️ -1s
69 tests ±0  69 ✅ ±0  0 💤 ±0  0 ❌ ±0 
70 runs  ±0  70 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8234f2f. ± Comparison against base commit 4ec71ea.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Win Test Results

 1 files  ±0  16 suites  ±0   4s ⏱️ ±0s
69 tests ±0  69 ✅ ±0  0 💤 ±0  0 ❌ ±0 
70 runs  ±0  70 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8234f2f. ± Comparison against base commit 4ec71ea.

@SimonWahlin SimonWahlin requested a review from PalmEmanuel July 3, 2025 08:30
@SimonWahlin SimonWahlin merged commit b10b7b3 into main Jul 3, 2025
7 checks passed
@SimonWahlin SimonWahlin deleted the BumpAzAuthDependency branch July 5, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants