refactor: Monolithic Decoupling & Stateless Multicast Stream Migration - #221
Closed
TotallyPresent wants to merge 3 commits into
Closed
TotallyPresent wants to merge 3 commits into
TotallyPresent wants to merge 3 commits into
Conversation
…epository and central MessageCoordinator
…align test data maps - Add missing coroutines, flexmark, and Ktor client core engine transit dependencies to app-tui build logic. - Fix abstract Presenter contract compliance by injecting clean onDetach lifecycle bodies into presenters. - Align MainMenuPresenter selection handling patterns and Auth session validation to leverage core domain interfaces. - Standardize test suite mocking models around native primitive types to drop legacy framework response wrappers.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 6ac2251. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This engineering refactor breaks down the legacy monolithic structure of the Roky repository, establishing a decoupled, Multi-Module Clean Architecture workspace. By separating core corporate rules from framework side-effects, we protect the project toolchain from version dependencies and prepare the user interface engine for upcoming roadmap targets (such as dedicated GUI or mobile applications) during our high-growth timeline.
Core Changes Implemented
:core(Domain Policy Layer): Houses pure framework-agnostic models (Message), abstract contracts (ReadChatRepository), and fake sandbox database mocks.:infrastructure-supabase(Data Adapter Layer): Encapsulates live network transmission rules, client setup, and remote table streams (v2.1.0SDK).:app-tui(Console Presentation Layer): Mounts the terminal execution loop, Lanterna window modules, layout panels, and presenters.Map<String, String>for profiles,Set<String>for presence tracking). Removed legacy monolithic envelope wrappers (PresenceResult,ProfileResult), eliminating type-casting hazards and downstream component dependencies inside the user interface.MessageCoordinatorto consume separate database synchronized tasks through a unified, long-lived hotSharedFlowmulticast structure, lowering system connection leaks and optimizing background thread performance profiles.settings.gradle.ktswith centralizeddependencyResolutionManagementrules (FAIL_ON_PROJECT_REPOS). This prevents layout drift by ensuring submodules draw strictly from checked repository networks.JUSTIFICATION FOR THE TEAMstructural markers andRESOLUTIONcontext comments across all new presenters and view architectures, supporting rapid code comprehension for incoming engineering contributors.Fixes # (If you have a ticket number from your project board, type it here—otherwise you can delete this line)
Type of change
Checklist: