Add more customization options#39
Draft
radugrecu97 wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that optimally, I wanted a size between Medium and Large for posters. A bit to difficult to see on the tv. Why not just make it fully customizable?
Disclaimer this was fully vibe coded. Of course, I did test it .
Yes, in the image the badges clip to the sides, but that's because all the ratings are at max digit length, which would never happen for an actual movie.
Therefore in practice it's not clipping the number but sometimes it clips the bounding box, which makes me want to group all ratings in the same rectangle background (like other poster services offer) to make it look better for this use case.
To do: