fix: defer triggered actions until after activation frame - #8
Draft
thomassedlmayer wants to merge 1 commit into
Draft
thomassedlmayer wants to merge 1 commit into
thomassedlmayer wants to merge 1 commit into
Conversation
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
thomassedlmayer
marked this pull request as draft
July 14, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes storyboard event handling so triggered actions are queued instead of being applied in the same frame that activates their start condition. The activation frame now remains unchanged, and action effects become visible in a following simulation step.
The current "immediate application" concept surfaced an exceeded MAE tolerance only for the falling-edge speed trigger validation case. I think this issue didn't appear for other similar test cases because the extra 1-frame lag between reference and tool trajectory accidentally didn't exceed the error tolerances while it did for the falling-edge case.
Scheduling options:
It would also be reasonable to increase the tolerated alignment lag from 1 to 2 in the corresponding test cases. With that, any scenario engine using "immediate application" would be tolerated by the validation suite.