feat: support IEC hardware addresses in struct members#1614
Open
feat: support IEC hardware addresses in struct members#1614
Conversation
Add support for AT %IX... hardware address declarations on struct member variables. The pre-processor now creates backing global variables (__PI_*, __M_*, __G_*) for struct members with hardware addresses and sets their initializers, mirroring the existing behavior for global variables. The lowering phase generates REF= assignments in the struct's constructor to wire up the pointer. Also introduces a shared FxHashSet to track generated hardware globals across pre-processor passes, preventing duplicate variable errors when the pipeline re-indexes during lowering.
| } | ||
|
|
||
| fn update_generated_globals(unit: &mut CompilationUnit, mangled_globals: Vec<Variable>) { | ||
| if mangled_globals.is_empty() { |
Contributor
There was a problem hiding this comment.
Will adding this .is_empty() check here have any unintended side effects? I see this method is also called from the existing methods as well.
Angus-Bethke-Bachmann
approved these changes
Mar 3, 2026
Contributor
Angus-Bethke-Bachmann
left a comment
Angus-Bethke-Bachmann
left a comment
There was a problem hiding this comment.
Looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for AT %IX... hardware address declarations on struct member variables. The pre-processor now creates backing global variables (_PI, _M, _G*) for struct members with hardware addresses and sets their initializers, mirroring the existing behavior for global variables. The lowering phase generates REF= assignments in the struct's constructor to wire up the pointer.
Also introduces a shared FxHashSet to track generated hardware globals across pre-processor passes, preventing duplicate variable errors when the pipeline re-indexes during lowering.