Skip to content

chore(deps): update node.js to 8094c00 #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update node.js to 8094c00 #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/test-adapter/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# See the Mulan PSL v2 for more details.


FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:8094c002d08262dba12645a3b4a15cd6cd627d30bc782f53229a2ec13ee22a00 AS base

RUN apk update && apk add libc6-compat python3 make gcc g++ git

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# See the Mulan PSL v2 for more details.


FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:8094c002d08262dba12645a3b4a15cd6cd627d30bc782f53229a2ec13ee22a00 AS base

RUN apk update && apk add libc6-compat python3 make gcc g++ git

Expand All @@ -23,7 +23,7 @@

RUN pnpm fetch

FROM base as pruner

Check warning on line 26 in docker/Dockerfile.docs

View workflow job for this annotation

GitHub Actions / build-images (docs, docs, BASE_PATH=/OpenSCOW/)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

WORKDIR /app

Expand All @@ -43,7 +43,7 @@

RUN pnpm build

FROM nginx:alpine@sha256:a5127daff3d6f4606be3100a252419bfa84fd6ee5cd74d0feaca1a5068f97dcf as runner

Check warning on line 46 in docker/Dockerfile.docs

View workflow job for this annotation

GitHub Actions / build-images (docs, docs, BASE_PATH=/OpenSCOW/)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

COPY docs/nginx.conf /etc/nginx/templates/default.conf.template
COPY --from=builder --chown=nginx:nginx /app/docs/build /etc/nginx/html/
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.scow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# See the Mulan PSL v2 for more details.


FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS base
FROM node:22-alpine@sha256:8094c002d08262dba12645a3b4a15cd6cd627d30bc782f53229a2ec13ee22a00 AS base

RUN apk update
Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基础镜像安装指令移除了 libc6-compat python3 make gcc g++ git 等依赖包，需要确认这些包是否确实不需要。如果后续构建或运行需要这些包，可能会导致问题。

Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与其他两个Dockerfile相比，此文件移除了python3、make、gcc、g++和git的安装。这可能导致某些依赖这些工具的构建步骤失败，建议保持一致或明确说明原因。

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git

Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相比其他Dockerfile，这里缺少了必要的构建依赖安装（如python3、make、gcc等），可能导致构建失败或功能缺失。建议保持一致

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git

Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除了python3 make gcc g++ git等依赖安装，需要确认这些依赖是否真的不再需要，否则可能会导致构建失败或运行时问题。

Copy link

@pkuhpc-review-bot pkuhpc-review-bot bot Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移除了python3/make/gcc/g++/git依赖的安装，请确认这是否会影响后续构建或运行时对相关工具的依赖需求

Suggested change
RUN apk update
RUN apk update && apk add libc6-compat python3 make gcc g++ git


Expand Down
Loading