Repository navigation
feat(skills): SkillBrain support files + 17 Matt Pocock skills - #14
Merged
Merged
Conversation
…k skills import Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ock skills Spec amended: walkDir and the support-file collector follow symlinks, since the container links lifecycle skill directories as symlinks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…irectories Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…are imported Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…18b) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…r-invoked skills Final-review fixes: a skill shipped in both bundle zones keeps the non-empty support-file set (vercel-react-best-practices, ui-ux-pro-max, hallmark, ...); support-file symlinks must resolve inside the skill directory and each directory is walked once; skill_read ignores a leading ./; AGENTS.md marks the 11 disable-model-invocation skills as user-invoked and notes upstream side effects; entrypoint comment corrected; spec, plan and DEPLOY-SKILLS updated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two connected changes:
SKILL.md/AGENT.md(formats, templates,references/,rules/) are now imported and readable throughskill_read({ name, file }). Until now onlySKILL.mdwas served, so existing skills that cite sibling files were broken over MCP:adsandasoreferences/,vercel-react-best-practicesrules/,hallmarkLICENSE.@3cca18b), limited to the ones the superpowers plugin does not already cover, wired intoAGENTS.md/CLAUDE.md.Design:
docs/superpowers/specs/2026-09-14-mattpocock-skills-integration-design.md· Plan:docs/superpowers/plans/2026-09-14-mattpocock-skills-integration.mdChanges
Part 1 — support files
037_skill_files.sqlandSkillsStore.replaceFiles / listFiles / getFile.packages/storage/src/import-skills.ts):walkDirnow follows symlinked skill directories. Without that, the entrypoint change below would have silently dropped every process skill from the prod import.data/skill/anddata/lifecycle-skills/, and the lifecycle copy has onlySKILL.md. These keep the non-empty file set.SKILL.mdtogether with its support files; the stored content is stillSKILL.md.skill_read:fileand ignores a leading./.file.entrypoint.shlinks wholelifecycle-skills/<name>directories, not only theirSKILL.md.Part 2 — 17 Matt Pocock skills
grilling,grill-me,grill-with-docs,to-questionnaire,wait-what,domain-modeling,codebase-design,improve-codebase-architecture,setup-matt-pocock-skills,to-tickets,triage,wayfinder,research,teach,wizard,resolving-merge-conflicts,handoff..agents/skills/(Codex, local import) andpackages/codegraph/data/lifecycle-skills/(prod bundle), plus_ATTRIBUTION-mattpocock-skills.mdandCATEGORY_MAP→Process.tdd,diagnosing-bugs,code-review,implement,to-spec,prototype,writing-for-agents: covered by superpowers.ask-matt,misc/*,in-progress/*.AGENTS.mdgains a "Skill di Matt Pocock (da SkillBrain)" routing table. The 11 skills markeddisable-model-invocation: trueupstream start only on the user's explicit request. It also notes upstream side effects:setup-matt-pocock-skillseditsCLAUDE.md, andresolving-merge-conflictscommits on its own.CLAUDE.md: do not install themattpocock-skillsplugin, since it duplicates superpowers.DEPLOY-SKILLS.mddocuments support files.First prod boot
A final review simulated the new boot layout over the real bundle with the branch's importer:
active, 34 support filesThe bundle hash changes, so the boot import re-runs. Migration 037 applies on
openDb().Test plan
pnpm --filter @skillbrain/storage test: 51/51. New: store files, support-file collection with limits, deletion on re-import, symlinked skill directory, unreadable file, malicious support file quarantined, dual-zone precedence, symlink containment, category mapping.packages/codegraph:tsc --noEmitclean, build ok, 315/315 (new:skill_readformatters,./normalisation).pnpm --filter @skillbrain/skill-guard test: 17/17.sh -nplus a simulated double boot over the old layout.diff -ridentical to upstream at the pinned SHA.skill_read("teach")lists support files;skill_read({ name: "teach", file: "MISSION-FORMAT.md" })returns it;skill_read("aso")andskill_read("vercel-react-best-practices")list their files;skill_routesurfacesgrilling,setup-matt-pocock-skills,codebase-design.Known follow-ups (not in this PR)
skill_updateandskill_scanstill scan onlySKILL.md, and review findings don't name the support file. No catalog skill is affected today.skill_readhandler wiring is covered bytsconly; the formatters have unit tests.🤖 Generated with Claude Code