Repository navigation
Conversation
…explicitly The reference-implementation shard jobs and the Postgres workflow ran on ubuntu-latest, which moved to ubuntu-26.04. Patchright publishes no Chromium build for that image, so its install step logs "Skipping the optional browser download" and `owner-connection-delete.test.ts` fails with "Executable doesn't exist at ~/.cache/ms-playwright/chromium_headless_shell-1243". The jobs only passed before because the shared node_modules cache restored a browser downloaded on the older image. Two causes, two fixes: - Pin the typecheck job, the test shards and the Postgres job to ubuntu-24.04, with a comment saying when to lift the pin. Key the node_modules cache by that image (v3) so a tree built on another image is never restored. - Install Chromium with `npx patchright install chromium` before the tests, so the cache no longer decides whether a browser exists. Tests are not changed to skip without a browser; a missing browser still fails. Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
Patchright publishes no Chromium build for ubuntu-latest (26.04), so its installer skips the download and the browser tests fail. This keeps ubuntu-latest, installs Google Chrome stable from Google's package, and runs the tests with PDPP_BROWSER_CHANNEL=chrome. Assisted-by: AI Signed-off-by: Tim Nunamaker <tnunamak@gmail.com>
Contributor
Author
|
Experiment done: all reference shards passed on ubuntu-latest. #622 now carries this tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment for #622: can the browser tests stay on ubuntu-latest (26.04)? Do not merge. If shard 3 passes here, #622 takes this approach instead of the pin.
Patchright publishes no Chromium build for ubuntu-latest (26.04), so its installer skips the download and the browser tests fail. This keeps ubuntu-latest, installs Google Chrome stable from Google's package, and runs the tests with PDPP_BROWSER_CHANNEL=chrome.
Assisted-by: AI