Skip to content

feat(language): merge translations - #3601

Open
tangge233 wants to merge 6 commits into
devfrom
language
Open

feat(language): merge translations#3601
tangge233 wants to merge 6 commits into
devfrom
language

Conversation

@tangge233

@tangge233 tangge233 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Sourcery 总结

增强功能:

  • 使用合并后的翻译更改更新法语和日语本地化资源。
Original summary in English

Sourcery 总结

增强功能:

  • 使用已合并的翻译更改更新法语和日语本地化资源。
Original summary in English

Sourcery 总结

增强功能:

  • 使用已合并的翻译更改更新法语和日语本地化资源。
Original summary in English

Sourcery 摘要

增强功能:

  • 使用已合并的翻译更改更新法语和日语本地化资源。
Original summary in English

Summary by Sourcery

Enhancements:

  • Update the French and Japanese localization resources with the merged translation changes.

flystuff233 and others added 2 commits September 5, 2026 15:18
Currently translated at 1.4% (43 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/fr/
Currently translated at 0.5% (16 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/ja/
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: M PR 大小评估:中型 labels Sep 5, 2026
@sourcery-ai

sourcery-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor
审查者指南(小型 PR 中折叠显示)

审查者指南

通过合并翻译变更来更新法语和日语 XAML 本地化词典,新增 61 行并删除 15 行;审查应重点关注键覆盖情况、重复或缺失的资源,以及翻译的正确性。

文件级变更

变更 详细信息 文件
合并并更新法语和日语语言包中的本地化资源条目。
  • 新增并修改法语翻译资源。
  • 新增并修改日语翻译资源。
  • 根据本地化架构或源语言,审查合并后的键及值的一致性。
PCL.Core/App/Localization/Languages/fr-FR.xaml
PCL.Core/App/Localization/Languages/ja-JP.xaml

提示和命令

与 Sourcery 交互

  • 触发新的审查: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub issue: 回复审查评论,请 Sourcery 根据该评论创建 issue。你也可以使用 @sourcery-ai issue 回复审查评论,以根据该评论创建 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置写入 @sourcery-ai,即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title,以随时生成或重新生成标题。
  • 生成拉取请求摘要: 在拉取请求正文中任意位置写入 @sourcery-ai summary,即可在指定位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary,以随时生成或重新生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可随时生成或重新生成审查者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,此功能非常有用。
  • 忽略所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。如果你想从头开始新的审查,此功能尤其有用——别忘了评论 @sourcery-ai review 以触发新的审查!

自定义你的使用体验

访问你的控制面板以:

  • 启用或停用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the French and Japanese XAML localization dictionaries by merging translation changes, adding 61 lines and removing 15; review should focus on key coverage, duplicate or missing resources, and translation correctness.

File-Level Changes

Change Details Files
Merge and update localized resource entries for French and Japanese language packs.
  • Add and revise French translation resources.
  • Add and revise Japanese translation resources.
  • Review merged keys and value consistency against the localization schema or source language.
PCL.Core/App/Localization/Languages/fr-FR.xaml
PCL.Core/App/Localization/Languages/ja-JP.xaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨——我已经审阅了你的更改,整体看起来很棒!


Sourcery 对开源项目免费——如果你喜欢我们的审查结果,请考虑分享它们 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da5c153ab5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +15 to +16
<sys:String x:Key="Application.EnvironmentWarning.Message">PCL CE は起動時に環境問題を検知しました:
これらの問題を解決しないと、一部の機能が正常に作動しない可能性があります……</sys:String>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the problem-list placeholder in the Japanese warning

When Japanese is selected and any startup environment check fails, _ShowEnvironmentWarning passes the detected issues to this resource as argument {0}, but this translation contains no placeholder. string.Format therefore discards the argument, so the dialog only reports a generic problem and omits whether the user needs to upgrade Windows, extract the launcher, or move it from a risky folder; include {0} in the message as the other locales do.

Useful? React with 👍 / 👎.

Currently translated at 5.1% (155 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/fr/
@pcl-ce-automation pcl-ce-automation Bot added size: L PR 大小评估:大型 and removed size: M PR 大小评估:中型 labels Sep 8, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bea12f9e3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

<sys:String x:Key="Crash.Analysis.Error.Failed">L'analyse du crash a échoué. Veuillez consulter les détails de l'erreur ci-dessous.</sys:String>
<sys:String x:Key="Crash.Dialog.Button.ExportReport">Exporter le rapport de crash</sys:String>
<sys:String x:Key="Crash.Dialog.Button.GoToModify">Aller modifier les paramètres</sys:String>
<sys:String x:Key="Crash.Dialog.Button.OpenLog">Modifier les paramètres</sys:String>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Label the log-opening button correctly

When French is selected and crash analysis provides a direct log without redirecting to instance settings, CrashDialogPresenter._GetSecondButtonText uses this resource while the button action opens the log via _OpenDirectFile. The current text means “Modify settings,” so the dialog presents an unrelated action and may cause users to overlook the available log; translate this as “View log” instead.

Useful? React with 👍 / 👎.

flystuff233 and others added 3 commits September 9, 2026 05:38
Currently translated at 5.3% (162 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/fr/
Currently translated at 0.5% (16 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/ja/
Currently translated at 5.6% (169 of 3014 strings)

Translation: Plain Craft Launcher Community Edition/launcher
Translate-URL: https://translate.pclc.cc/projects/pcl-ce/launcher/fr/

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49f8906cca

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

{0}</sys:String>
<sys:String x:Key="Crash.Report.Export.Success">Rapport de crash exporté!</sys:String>
<sys:String x:Key="Crash.Report.SaveDialog.DefaultFileName">Rapport de crash-{0}.zip</sys:String>
<sys:String x:Key="Crash.Report.SaveDialog.Filter">Rapport de crash Minecraft (.zip)|.zip</sys:String>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore wildcards in the crash-report file filter

When French is selected and the user exports a crash report, this value is passed directly to SaveFileDialog.Filter, but .zip matches only a file literally named .zip rather than ZIP files generally. Existing ZIP reports are therefore hidden, and extension inference may not work if the user removes the extension from the default name; use *.zip as in the other locale resources.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L PR 大小评估:大型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants