Skip to content

fix(login-auth): 仅在确认支持 OAuth 时显示登录入口 - #3594

Merged
Chiloven945 merged 1 commit into
devfrom
fix/isOAuthAvailable
Sep 3, 2026
Merged

fix(login-auth): 仅在确认支持 OAuth 时显示登录入口#3594
Chiloven945 merged 1 commit into
devfrom
fix/isOAuthAvailable

Conversation

@LuLu-ling

@LuLu-ling LuLu-ling commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Bug Fixes:

  • 仅在明确确认 OAuth 受支持时显示 OAuth 登录入口,避免在支持状态未知时错误展示。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • 仅在明确确认 OAuth 受支持时显示 OAuth 登录入口,避免在支持状态未知时错误展示。

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels Sep 3, 2026
@LuLu-ling
LuLu-ling requested a review from a team September 3, 2026 12:46
@sourcery-ai

sourcery-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
审查者指南(小型 PR 中折叠显示)

审查者指南

收紧 OAuth 登录入口的显示条件,避免在 OAuth 支持状态未知时展示入口;未知或不支持时隐藏 OAuth 按钮并让密码网页登录入口占满布局。

文件级变更

变更 详情 文件
仅在明确确认支持 OAuth 时显示 OAuth 登录入口,并在不可用时扩展密码网页登录入口。
  • 将 OAuth 可用性判断从“未明确不支持”改为“明确支持”
  • 根据 OAuth 可用性切换 OAuth 按钮可见性及密码网页登录按钮的列跨度
Plain Craft Launcher 2/Pages/PageLaunch/PageLoginAuth.xaml.cs

提示和命令

与 Sourcery 交互

  • 触发新的审查: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 根据审查评论生成 GitHub issue: 回复审查评论,请 Sourcery 根据该评论创建 issue。你也可以回复审查评论并使用 @sourcery-ai issue,根据该评论创建 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置输入 @sourcery-ai,即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title,以随时(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任意位置输入 @sourcery-ai summary,即可在指定位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary,以随时(重新)生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可随时(重新)生成审查者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 忽略所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。如果你想从新的审查开始,这尤其有用——别忘了评论 @sourcery-ai review 来触发新的审查!

自定义使用体验

访问你的控制面板以:

  • 启用或禁用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

收紧 OAuth 登录入口的显示条件,避免在 OAuth 支持状态未知时展示入口;未知或不支持时隐藏 OAuth 按钮并让密码网页登录入口占满布局。

File-Level Changes

Change Details Files
仅在明确确认支持 OAuth 时显示 OAuth 登录入口,并在不可用时扩展密码网页登录入口。
  • 将 OAuth 可用性判断从“未明确不支持”改为“明确支持”
  • 根据 OAuth 可用性切换 OAuth 按钮可见性及密码网页登录按钮的列跨度
Plain Craft Launcher 2/Pages/PageLaunch/PageLoginAuth.xaml.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@LuLu-ling LuLu-ling removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels Sep 3, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨——我已经审阅了你的更改,看起来很棒!


Sourcery 对开源项目免费——如果你喜欢我们的审查结果,欢迎考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我会利用你的反馈来改进审查结果。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pcl-ce-automation pcl-ce-automation Bot added the 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 label Sep 3, 2026
@pcl-ce-automation pcl-ce-automation Bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Sep 3, 2026
@Chiloven945
Chiloven945 merged commit 6bb84d7 into dev Sep 3, 2026
3 checks passed
@pcl-ce-automation pcl-ce-automation Bot added 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 size: XS PR 大小评估:微型 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Sep 3, 2026
@Chiloven945
Chiloven945 deleted the fix/isOAuthAvailable branch September 3, 2026 14:38
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 and removed 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS PR 大小评估:微型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants