Repository navigation
docs: record the reason for the Rust 1.84 MSRV - #46
Merged
Merged
Conversation
ADR 0018 now says why the MSRV may exceed that of windows-sys and of the `windows` crate. windows-spawn adds convenience over those bindings, so a project that must build with an older Rust can call windows-sys directly. The ADR also says that only the maintainer moves the MSRV, and it rejects Rust 1.82 and an MSRV that follows windows-sys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #45.
ADR 0018 now says why the MSRV may exceed that of the Windows bindings, and who moves it.
windowscrate 0.62 requires Rust 1.82.This crate adds convenience over those bindings, so a project that must build with an older Rust can call windows-sys directly.
Validation
cargo inforeported rust-version 1.71 for windows-sys 0.61.2 and 1.82 for windows 0.62.2.prose check --channel documentreports nothing on the new lines.Checklist
@coderabbitai ignore