Initial pass at IMM training#28
Open
voetberg wants to merge 4 commits into
Open
Conversation
kpedro88
reviewed
Jul 18, 2025
Contributor
Author
|
I rebased and removed some of the diverging plotting code - lmk if this is okay to merge |
Owner
|
Can you post some plots of the performance you are getting with the IMM model before we merge? |
Contributor
Author
|
Performance is pretty split. It gets really good things like EnergyZ, but fails miserably at Phi and EnergyR. EnergyZ logy Scatter ES TotalE PhiCenter RCenter Sparsity Voxel E Logy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to clean up the IMM repo code to put it into a usable state. Implemented the IMM loss with the Pushforward sampler for inference, with basic tests. Have not yet trained a model with this yet, it is subject to change.