Upgrade TRE - tvstre-prod-main-v0.27.X - Continued - #75
Closed
JaimieWi wants to merge 6 commits into
Closed
Conversation
Applied workflow changes required for federated credential support that exist upstream but were not yet reflected in this deployment repo (previously only carried forward as far as an earlier release). - action.yml - clean_validation_envs.yml - deploy_tre_branch.yml - deploy_tre_reusable.yml - lets_encrypt.yml Also removes the nightly scheduled run from deploy_tre.yml (midnight cron trigger) as it is not required for our deployment model, and updates the file's header comment to reflect this. cli-package.yml and pr_comment_bot.yml intentionally not added - not applicable to our setup (no AzureTRE CLI in use). Files that exist only in the upstream AzureTRE repo (not AzureTRE-Deployment) were out of scope for this change.
- pipelines stuck, force commit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRE run id: tre58c5d4df
CONTINUED - see #74 for previous state
Summary
This PR upgrades the TRE to incorporate upstream changes from v0.27.0 (v0.26.0 skipped — see linked YouTrack ticket for rationale), along with CI/CD authentication changes required to support the new version.
Full breakdown of breaking changes, testing checklist, and decision log: https://oxbrcdw.myjetbrains.com/youtrack/issue/DEV-1968/Upgrade-TRE-to-tvstre-prod-main-v0.26.0-v0.27.0
Upstream Changes
v0.27.0
Breaking changes reviewed (full detail in linked ticket)
v0.26.0 (picked up as part of this upgrade)
CI/CD Changes
TVS SDE Custom Changes
Ongoing - Errors and Logs during upgrade
Error 1: Terraform init — Azure CLI auth incompatible with Service Principal
Error: "Authenticating using the Azure CLI is only supported as a User (not a Service Principal)"
Cause: register_tre_bundle.yml wasn't passing AZURE_CLIENT_ID/TENANT_ID/SUBSCRIPTION_ID through to the Deploy management step, so Terraform fell back to CLI auth.
Fix: Updated register_tre_bundle.yml to pass these through. Pending re-run confirmation.