Repository navigation
Add Sleep Room ground-floor landmarks, gated areas and stairs - #78
Closed
LittleCarbs wants to merge 3 commits into
Closed
LittleCarbs wants to merge 3 commits into
LittleCarbs wants to merge 3 commits into
Conversation
Contributor
|
Thanks a lot for this, @LittleCarbs ! Zoning all 18 rooms and adding the landmarks already makes the Sleep Room much easier to read. Before we merge, a few things:
Once this is in, you'll be credited in meta.authors and contributors.json with your outlasttrialsstats.com profile, which also unlocks the Map Contributor badge. Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds ground-floor annotations based on my Sleep Room walkthrough and the attached reference, preserving SuprexDE’s existing 18-room outline.
Marker positions and staircase footprints are approximate and would benefit from maintainer review. This contribution covers the ground floor; upstairs geometry and precise door openings remain to be mapped.
Seven namespaced landmark definitions and three namespaced color zones are appended to the shared libraries.
Which map and trials are affected?
sleep-room)main, Base Floor (0)Your credit (optional)
Please link this contribution to my profile for the Map Contributor badge if accepted. Existing map author credit is preserved for the maintainers to update.
Validation
map.jsonis omitted from the diff.Checklist
map.json, the trial files, andelements.json/zones.jsonif changed) come from the web editor (validation ran before export)Reference