Sync fork with upstream master - January 2026 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow showing icons or other custom content in selected item when the select is closed
This reverts commit abaf05d.
Co-authored-by: Arnaud Benhamdine <abenhamdine@users.noreply.github.com>
…ySemenko/virtual-select into add-icons-to-selected-item
* Add new properties additionalDropboxClasses and additionalToggleButtonClasses * Added new option additionalDropboxContainerClasses * Update virtual-select.types.js
Support icons in selected item also, not only in list of options
Fix Dropdown Search/Tags accessibility issues
- Instead the the focus is now called in specific cases, for example, when pressing ESC to close the dropbox.
This reverts commit b98d55a.
Co-authored-by: José Rio <jose.rio@hotmail.com>
* Focus wrapper element once gets closed. * Fixing shift tab navigation once triggered at search input. * Focus wrapper element once gets closed. * Update compiled. * set a11y attributes to the wrapper element. * Enable toggleAllOptions when Enter key is pressed and toggle-all-button is focused * Fixing toggling of all option when any key was pressed and toggle-all-button was focused --------- Co-authored-by: José Rio <jose.rio@hotmail.com> Co-authored-by: gnbm <goncalo.martins@outsystems.com>
* Updated focus behaviour. * fixed setting focus issue.
- Fixed typo on `enableSecureText` description withing the documentation - Updated some dev dependencies from the project - Fixed issue #365 associated with a XSS vulnerability (`enableSecureText` most the set to true for this to be applied)
…wDuration and hideDuration as options (#390) * Call removeEvents() even when no dropboxWrapper is specified * Expose showDuration and hideDuration options * PR review changes Co-Authored-By: Gonçalo M. <goncalo.martins.fct@gmail.com> --------- Co-authored-by: Gonçalo M. <goncalo.martins.fct@gmail.com>
* Improve a11y keyboard navigation and screen readers feedback * Added new property and better sort text properties. * Update dist files. * strip html tags when setting aria-label. * Update dist files * Update docs files * Removed 'this' context due static method. * Fixed test * Fix issue related with options be hidden. * Added new aria text attribute * Update compiled files. * Solve conflicts * Update dist files * Remove duplicated property
* Standardize line endings * Fix Snyk finding Fixed Snyk finding that stated that the static function isEmpty should not be accessed with this. Use the class instance name instead.
* Increment version to 1.0.48
* Avoid setSearchValue executing when the value didn't change * Normalize values to prevent boolean conversions * Remove test validation for other issue
… (#413) * Improve conditions to apply normalizeString * Improve readability Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> * Improve readability in the validations * Update virtual-select.js --------- Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com>
…e open the dropdown (#415)
Improved label validation: only use labelNormalized if it exists AND is not undefined/null
…new one (#418) * Add tests for dropdowns interactions * Introduce a way to manage open instances
… while another is opened (#421) * Added mechanism to manage focused instances * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added the keepAlwaysOpen validation --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix: onChange event is fired twice when select from search input * + example and tests for onchange events * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update cypress/e2e/examples.cy.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * lint suggest string for search * remove inline styles * Move onchange example to Events page --------- Co-authored-by: Gonçalo M. <goncalo.martins.fct@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: gnbm <goncalo.martins@outsystems.com>
* fix: onChange event is fired twice when select from search input * + example and tests for onchange events * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update cypress/e2e/examples.cy.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * lint suggest string for search * remove inline styles * Add new tests * Update docs/events.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Review examples for consistency across others --------- Co-authored-by: Vladimir Varlamov <bes.internal@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add more examples to complement the Events page Add more examples to complement the Events page to include the Open / Close and Reset scenarios. * Complement open/close events samples * Update docs/events.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update script.js * Update docs/assets/script.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/assets/styles.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add new test for the reset event * Improve sample code --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…'t work as expected (#427) * Fix focus behavior on elements like an input that didn't work as expected * Added test to validate focus management clicking outside and pressing ESC * Extract the focus management logic into a dedicated helper function Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "Extract the focus management logic into a dedicated helper function" This reverts commit 048ef533a5590abbe4433979196157aaa0aefa83. * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples.cy.ts * Update docs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed options onScroll focus issue. * Adapting tests * removed unneeded stuff
…'t work while input search is focused (#435) * Allow default behavior when search input is focused Allow default behavior (cursor movement) when search input is focused * Add more tests for search input
* Update packages * Update packages and Sass * Update .editorconfig Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/sass/styles.scss Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .editorconfig Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .editorconfig --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Improve code to avoid memory leaks * Add validations before removing events * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/virtual-select.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix regression issue when using keyboard navigation * Update the focused element when it gets closed
* Update npm-publish.yml * Update .github/workflows/npm-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/npm-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/npm-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update npm-publish.yml * Update .github/workflows/npm-publish.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…essibility (#451) * Improve accessibility with aria-setsize and aria-posinset attributes for virtualization * Add tests for Accessibility attributes - virtualized options metadata * Fix syntax error on tests * Update examples.cy.ts
…ith ARIA attributes (#453) * Fix screen reader announcement when dropdown focused * Added aria-labelledby to the scrollable options container Added aria-labelledby to the scrollable options container (vscomp-options-container) to improve screen reader announcements. * New Test: has proper ARIA attributes on listbox and options container for screen reader navigation * Update virtual-select.js * Fix test aftre structure change
* Increment version to 1.1.3 * Increment version to 1.1.3 with updates
When the dropdown was open, and one option was focused, the browser attempted to keep the focused option visible. This created a strange behaviour on the scroll
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. Pull Request Developer GuidancePlease contact the Security Office if you encounter issues with Wiz PR scanning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR synchronizes this fork with the latest changes from the upstream repository
sa-si-dev/virtual-select.What was done
masterinto a dedicated sync branchWhy
Keeping the fork aligned with upstream ensures:
Notes for reviewers