feat: add new UI components including Navbar, Hero, BentoGrid, and Ka… #64
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "ci": { | ||
| "collect": { | ||
| "startServerCommand": "npm run preview", | ||
| "url": [ | ||
| "http://localhost:4173/" | ||
| ], | ||
| "numberOfRuns": 3 | ||
| }, | ||
| "assert": { | ||
| "preset": "lighthouse:recommended", | ||
| "assertions": { | ||
| "categories:performance": [ | ||
| "error", | ||
| { | ||
| "minScore": 0.9 | ||
| } | ||
| ], | ||
| "categories:accessibility": [ | ||
| "warn", | ||
| { | ||
| "minScore": 0.9 | ||
| } | ||
| ], | ||
| "categories:best-practices": [ | ||
| "warn", | ||
| { | ||
| "minScore": 0.9 | ||
| } | ||
| ], | ||
| "categories:seo": [ | ||
| "warn", | ||
| { | ||
| "minScore": 0.9 | ||
| } | ||
| ], | ||
| "first-contentful-paint": [ | ||
| "warn", | ||
| { | ||
| "maxNumericValue": 2000 | ||
| } | ||
| ], | ||
| "largest-contentful-paint": [ | ||
| "error", | ||
| { | ||
| "maxNumericValue": 2500 | ||
| } | ||
| ], | ||
| "cumulative-layout-shift": [ | ||
| "error", | ||
| { | ||
| "maxNumericValue": 0.1 | ||
| } | ||
| ], | ||
| "total-blocking-time": [ | ||
| "warn", | ||
| { | ||
| "maxNumericValue": 200 | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "upload": { | ||
| "target": "temporary-public-storage" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Lighthouse CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| lighthouse: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build | ||
| run: npm run build | ||
|
|
||
| - name: Run Lighthouse CI | ||
| uses: treosh/lighthouse-ci-action@v11 | ||
| with: | ||
| uploadArtifacts: true | ||
| temporaryPublicStorage: true | ||
| configPath: ./.github/lighthouse/lighthouserc.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. 🟡 Missing clearTimeout on component unmount causes potential memory leak The scroll handler in Navbar.tsx doesn't clear the pending timeout when the component unmounts, which can cause a memory leak and React state update warnings. Click to expandIssueIn the scroll effect at useEffect(() => {
let timeoutId: NodeJS.Timeout;
const handleScroll = () => {
if (timeoutId) return;
timeoutId = setTimeout(() => {
setIsScrolled(window.scrollY > 50);
timeoutId = undefined!;
}, 100);
};
window.addEventListener('scroll', handleScroll);
return () => window.removeEventListener('scroll', handleScroll);
}, []);Actual vs Expected
ImpactThis can cause "Can't perform a React state update on an unmounted component" warnings and minor memory leaks during rapid navigation. (Refers to lines 37-48) Recommendation: Add 
Was this helpful? React with 👍 or 👎 to provide feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Penggunaan
will-change-transformdi sini mungkin tidak memberikan manfaat performa yang diharapkan dan berpotensi menyebabkan penggunaan memori yang tidak perlu. Propertiwill-changesebaiknya diterapkan langsung pada elemen yang akan dianimasikan.Dalam kasus ini, animasi
transform(sepertiscalepada gambar atauypada kartu) terjadi pada elemen lain (elemenmotion.divinduk atauimgdi dalamnya). Sebaiknya hapuswill-change-transformdaridivini. Jika optimasi spesifik diperlukan, terapkan langsung pada elemen gambar yang memiliki transisiscale.