Enhance custom model entry visibility#2089
Conversation
openai0229
left a comment
There was a problem hiding this comment.
Thanks for improving the visibility and accessibility of the custom-model entry. The code change is scoped to the frontend, the entry is now a real button, and the current frontend CI passes.\n\nBefore this can be merged, please complete the pull-request contract:\n\n1. Link the approved Issue in (the current is empty) and explain the user-visible problem this change is intended to solve.\n2. Complete every PR-template section, including the affected Frontend/Web checkbox, exact verification commands and results, risk/compatibility notes, reviewer map, and contributor declarations.\n3. Add before/after screenshots or a short recording for both dropdown states: no configured models and at least one configured model. Please include the click-through to model settings and keyboard activation of the new button.\n\nThis is necessary because the patch changes the trigger width, placeholder, dropdown width, hover/focus behavior, and the empty-state action at the same time. CI can verify compilation and linting, but it cannot establish that the intended visual behavior is correct or that the settings entry remains usable in both dropdown states. Once the Issue, completed template, and UI evidence are present, the implementation can be reviewed against a concrete expected behavior.
Formatting issue in the submitted review; replaced by the corrected review below.
openai0229
left a comment
There was a problem hiding this comment.
Thanks for improving the visibility and accessibility of the custom-model entry. The code change is scoped to the frontend, the entry is now a real button, and the current frontend CI passes.
Before this can be merged, please complete the pull-request contract:
- Link the approved Issue in
Related issue(the currentCloses #is empty) and explain the user-visible problem this change is intended to solve. - Complete every PR-template section, including the affected Frontend/Web checkbox, exact verification commands and results, risk/compatibility notes, reviewer map, and contributor declarations.
- Add before/after screenshots or a short recording for both dropdown states: no configured models and at least one configured model. Please include the click-through to model settings and keyboard activation of the new button.
This is necessary because the patch changes the trigger width, placeholder, dropdown width, hover/focus behavior, and the empty-state action at the same time. CI can verify compilation and linting, but it cannot establish that the intended visual behavior is correct or that the settings entry remains usable in both dropdown states. Once the Issue, completed template, and UI evidence are present, the implementation can be reviewed against a concrete expected behavior.
Related issue
Closes #
Summary
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: N/A