Repository navigation
Conversation
|
Thanks for making registered model runtimes honor the owner's reasoning mode through the shared compatibility helper. Advisory status: needs human decision The launcher change fits the existing design: it probes the selected registered executable through The description still records a failed strict four-case hardware matrix and a pending supplemental on-mode control. The successful off-mode start/restart results support the intended fix; exhausting a 64-token on-mode budget does not by itself demonstrate a regression. Before calling integration accepted, please complete and record the proposed 256-token positive control under the existing admission limits, or have a human maintainer explicitly resolve that acceptance item. Keep the original failed matrix visible as documented. What I checked:
|
Summary
Fixes #8168. Native Windows models launched from a registered model store now honor
LLAMA_REASONINGusing the selected runtime's supported flags, just as the default pinned runtime does.The registered branch used
--reasoning-format noneunconditionally. On b9014 this leaves thinking enabled, so a short question can spend its entire answer budget on a visible thinking trace. Pass the mode through the existingGet-ODSNativeReasoningArgshelper against the registered executable, keeping its older-runtime fallbacks and the profile's qualified tuning arguments.Why this matters
ods.ps1 native-llm-startis the native sign-in task's entrypoint.native-llm-restartuses the same launch preparation, including host-agent model activation and rollback. An owner who sets thinking off should receive the answer through these paths, including when using an additional model store.Overlap check
Searched open/closed PRs for registered runtimes, reasoning,
ChatTemplateFileand the changed launcher's callers. Merged #8151 normalizes mode case but leaves this registered branch format-only; merged #6685 handles macOS defaults. Open #6728 addresses selector/context parity. #8014 adds CUDA pin/routing support, while RFC #7968's desktop stack remains separate pending work. This patch changes one shared Windows launcher and three existing tests; it adds no desktop implementation or parallel runtime.AI Assistance
tang-vuleads this Windows reliability contribution and its technical direction, scope and quality requirements, collaborating with Codex on investigation, implementation, regression tests and review. The validation commands below were executed by Codex. An independent Codex source review found no blocking findings; maintainer release approval remains separate.Release Lane
mainChanged Surface
Risk And Validation
Risk: High, because native model launch arguments change. Scoped real-hardware validation exercises the affected Windows entrypoints and inference; it is not a full installer/fleet run.
Windows 10 Pro x64 build 19045, non-elevated owner token, PowerShell 5.1 and portable PowerShell 7. Main base
de84ff85dad7a95a12fcf2c737b7fc9496e8efcc. An isolated installation layout contains the exact tracked-main export, the real registered-store resolver, an official SHA-verified b9014 Vulkan runtime, and catalog SHA-verified Qwen3.5-2B Q4_K_M. CPU route, 4096 context, one slot, eight threads. No Docker, WSL or task registration.2+2, number only; temperature 0, seed 42, max 64 tokensnative-llm-startnative-llm-restart--reasoning-format none--reasoning off4lengthstopOnly the changed launcher file was replaced between these real runs; model, runtime and configuration were unchanged. Artifact qualification and the launcher's model/context readiness proof both executed normally. No API request disabled thinking on behalf of the launcher.
Validation:
ci-suite.txt; no workflow change. Inventory: 1380 tests, 1361 executed / 19 documented exclusions.git diff --checkgates pass. The real inference validation used3619e42f0; final headf593974c9retains exactly the same production bytes.test-llama-reasoning-format.sh, which still required the registered branch's format-only flag. The follow-up updates that contract to require the same selected-runtime qualification now protected behaviorally. The corrected shell contract passes locally; production bytes and the real inference receipts are unchanged.Operational Change Check
The scoped equivalent proves the actual Windows start/restart path, registered artifact validation, selected-binary flags and real inference. Full clean installation, Windows 11, actual sign-in/reboot, AMD GPU execution, other live llama.cpp versions and the release fleet remain deferred to the appropriate maintainer lane. Existing profile tuning and the pinned-runtime branch retain their previous contracts. Rollback is a revert followed by a normal native restart.
Hosted CI on final head
f593974c9e50f81747fb8b21ed0aaf9d791226b3: 73/73 checks successful. The first-head failure and its static-contract correction are preserved above.Independent fleet verification - 2026-10-25
The independent Windows run now reproduces the bug and demonstrates the off-mode fix through the real
native-llm-startandnative-llm-restartCLI paths. It uses the verified Qwen3.5-2B Q4_K_M model and registered runtime, two CPU threads, no GPU layers, and identical prompt, seed, temperature and 64-token budget.4, two completion tokens, normal stop.Cleanup verified no owned native process or qualification listener remained, fixture keys were removed, and immutable files were reverified. A separate 256-token positive on-mode control is prepared. Its first attempt was refused before runtime startup because the fixture key had already been redacted by cleanup; the repaired successor was refused by the fresh 5-GiB free-RAM gate, also before runtime startup. No admission limit was lowered. This supplemental control and final integration acceptance remain pending; the PR is unmerged.
Original matrix receipt SHA-256:
e34b54e280a32a5d23255d013cfd16597a058d26bd803ef0f6c094441849acb1. These are independent fleet results; the contributor validation above is preserved.