Repository navigation
fix(windows): write compose diagnostic failure reports literally - #8155
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Oct 25, 2026
vaibhavsrv
force-pushed
the
fix/windows-compose-diagnostics-literalpath
branch
from
October 25, 2026 12:27
d4e4830 to
12bae1a
Compare
This was referenced Oct 25, 2026
vaibhavsrv
force-pushed
the
fix/windows-compose-diagnostics-literalpath
branch
from
October 25, 2026 12:47
e480eb0 to
a6f8d9d
Compare
6 tasks done
vaibhavsrv
force-pushed
the
fix/windows-compose-diagnostics-literalpath
branch
from
October 25, 2026 13:15
a6f8d9d to
2930c01
Compare
Contributor
Author
|
Integrated into main via #8165 with co-authorship. Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8154.
Compose failure diagnostics now save reports under install directories containing square brackets, including fresh Docker client configuration, command working directories, and failed-image log discovery. The new controls exercise the outer SaveReport path, preserve caller state, and verify that a wildcard-matching neighbor remains untouched.
Release lane and changed surface
Mainline change targeting
main; Windows installer/CLI diagnostics. Operational change with narrowly scoped native Windows validation. No full installer or fleet-green claim.Validation
Reviewed head
e480eb0df84d8f8ca134e991d594afbf88e08862.git diff --checkand changed production scripts passed the repository PSScriptAnalyzer rules.test-windows-runtime-recovery.ps1passed on this Windows laptop under Windows PowerShell 5.1.26100.9711 and PowerShell 7. The expanded tests reproduced the remaining failure before the repair, then passed with it. Filesystem operations and path bindings are real; command/network/hardware doubles in the contract tests are explicit.Separate native runs used the real production entry path and real Docker CLI under both PowerShell versions, an isolated bracketed install fixture, an empty Docker config, and a deliberately unavailable named-pipe Docker endpoint. Reports were saved successfully; no running ODS installation or Docker service was changed. Fixture directories were removed after verification.
GitHub CI for this head must finish before merge. Broader Portal/model-switch/fleet acceptance remains separate.
Risk and AI assistance
Scoped support-diagnostics repair. Shared path readers keep their existing selection behavior while treating filesystem names literally. AI assisted investigation, edits, and validation; Codex independently reviewed source and native execution evidence. This is not a claim of independent human review.
Current main refresh:
d15c97ed550adb4f30d24db6776c3e61cff7b57cis included at heade480eb0df84d8f8ca134e991d594afbf88e08862. This merge changes only the Python 3.9 CI runner; the entire candidateods/tree is identical to its pre-refresh source. CI for this new head is pending.The contract test now exits successfully after its deliberately failed Docker fixture; both PowerShell versions passed the GitHub Actions-style invocation. Production sources are unchanged by that follow-up.