Repository navigation
fix(pixel): charge suppressed errors in chained grep lookups - #7702
Draft
Lightheartdevs wants to merge 1 commit into
Draft
Lightheartdevs wants to merge 1 commit into
Lightheartdevs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier
grep -scan fail silently with exit 2, while a later empty grep makes the whole command exit 1. The empty-lookup exemption added in #7701 then treated the failed chain as discovery and did not charge its failure budget.Require an earlier grep with diagnostic suppression to retain its own final exit status, matching the existing restriction for
rg. This covers grep/egrep/fgrep, clustered short flags, GNU's long-option abbreviation and quoted options. Final bare lookups and ordinary search chains retain their existing behavior; progress limits and tool permissions are unchanged. Option-shaped operands are conservatively charged.Validation:
29d01c60819ae830412c7dea01c47e00f03a430c.Draft pending installed qualification. No product runtime or host was changed by this patch.