Skip to content

fix(settings): preserve saved apply plans during pending runtime changes - #7263

Merged
Lightheartdevs merged 1 commit into
Osmantic:mainfrom
tang-vu:fix/dashboard-runtime-settings-20261004
Oct 8, 2026
Merged

Lightheartdevs merged 1 commit into
Osmantic:mainfrom
tang-vu:fix/dashboard-runtime-settings-20261004

Conversation

@tang-vu

@tang-vu tang-vu commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Exclude edits, saves, reloads and refreshes while apply or reads are pending; preserve the saved plan after failures and unlock for retry.

Reconstructed only the reviewed #7263 scope on current upstream main b4f015a921c59eeb20317c5f48adf2dfb43b1430. Local candidate 3262be3c7979a525ecf7e00771d978af2b3eec8f; previous published head 45c372c975558ab29526a4ef9a93e353ef9c80f2 is retained locally under refs/archive/ods-20261004/pr-7263. No behavioral changes were added during reconstruction; current-main changes outside this scope are preserved.

Issue association: Closes #7297.

AI Assistance

The human contributor and Codex collaborated on this PR. The contributor provided project direction, scope decisions and environment setup; Codex assisted with analysis, implementation or reconstruction, tests, review and PR preparation. The validation commands were executed by Codex, with results and limitations documented in this PR. The human contributor remains responsible for the final changes and validation claims. Maintainer review and applicable release gates remain required before merge. Earlier independent AI review receipts apply only to their recorded heads; current-candidate validation is identified separately in this PR.

Release Lane

  • Mainline change targeting main

Changed Surface

  • Dashboard UI

Risk And Validation

  • Risk level: Medium

  • git diff --check

  • Focused tests

  • Commit identity gate against exact current-main base/candidate

23 rendered Settings tests passed. Production Vite build passed; ESLint on three changed files reported 0 errors and 52 warnings.

The focused results were run on the exact candidate file tree before committing; the commit only recorded that tested tree. Original-head/full native and combined integration receipts remain archived, and are inherited evidence rather than fresh install or new-head hosted CI results.

CI execution: dashboard.yml runs npm test for the dashboard.

Operational Change Check

  • Operational validation intentionally deferred: full fresh install, live model/GPU, Portal, hardware/release fleet and platform-specific lanes not explicitly exercised above. Root's separate current-main installation is not yet candidate validation.

Notes For Reviewers

Rendered jsdom tests exercise promises and controls; live browser/host recreation and cross-tab/router navigation are unverified.

Rollback: revert this scope; preserve existing recovery receipts and configured data. Local native tests and green original-head CI do not replace human review or deployed-runtime gates.

@tang-vu
tang-vu force-pushed the fix/dashboard-runtime-settings-20261004 branch from 45c372c to 3262be3 Compare October 4, 2026 09:54
@Lightheartdevs
Lightheartdevs merged commit 63adf10 into Osmantic:main Oct 8, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings apply completion can clear the plan for a later saved change

2 participants