Repository navigation
fix(dashboard-api): guard null throughput values in agents metrics html - #6341
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/routers/agents.py,get_agent_metrics_htmlformats throughput values into the HTML fragment usingf"{tp.get('current', 0):.1f}"andf"{tp.get('average', 0):.1f}". When telemetry feeds report uninitialized or null metrics (i.e.{"current": None, "average": None}),dict.getreturnsNoneinstead of the fallback0. PassingNoneto the:.1fformat specifier immediately raises an unhandledTypeError: unsupported format string passed to NoneType.__format__, causing HTTP 500 errors on dashboard monitoring requests.This change surgically applies
float(tp.get('current') or 0)andfloat(tp.get('average') or 0)prior to formatting, cleanly defaultingNoneor empty throughput values to0.0without altering existing card styling or HTML structure.Validation
get_agent_metrics_htmlwiththroughput: {"current": None, "average": None}raisedTypeError: unsupported format string passed to NoneType.__format__.get_agent_metrics_htmlrenders0.0tokens/sec without exception and returns HTTP 200.Overlap check
Recent PRs #6340 (pre-download option validation), #6337 (migrate-config environment diff), and #4270 (timestamp null-guard in agents metrics) address separate paths. This PR isolates throughput formatting in
routers/agents.pywithout conflicting with adjacent dashboard features.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6340 at 3df0a85 without conflicts. Production and test diffs passed together; agents and dashboard checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.