Skip to content

fix(pixel-agent-teams): guard null row record in TeamStore list lookup - #5974

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-list-null-guard
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-list-null-guard

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_agent_teams.py, TeamStore.list(self, owner, chat) iterates over matching team JSON files and invokes row = self.get(owner, path.stem[65:]). If a team file is unreadable, removed concurrently, or corrupted, self.get() returns None. Accessing row["chat_id"] then crashes with TypeError: 'NoneType' object is not subscriptable.

This surgical fix verifies row is not None and row.get("chat_id") == chat in TeamStore.list.

Validation

  • Baseline reproduction: verified that self.get() returning None caused TypeError on baseline.
  • Post-fix behavior: safely skips unreadable rows and returns valid matches.
  • Telemetry: pixel-agent-teams suite: 1 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5807 validated questions format; zero overlap with TeamStore list null handling.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Enforces resilience during team history listing. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 6a408cc85 without conflicts. CI and unit checks pass.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants