fix(dashboard-api): ensure trailing buffered chunk is newline-terminated before done marker - #5946
Open
vaibhavsrv wants to merge 1 commit into
Open
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
…ted before done marker
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/routers/pixel.py,pixel_chat_streamstreams SSE events from upstream services to authenticated clients. When reading chunks from upstream,bufferedaccumulates raw bytes and yields complete lines split on\n. At the end of the stream, ifbufferedretains trailing bytes (for example, when upstream closes connection without terminating its last SSE data payload with a trailing newline), the handler yieldsbytes(buffered)followed immediately byb"data: [DONE]\n\n".Yielding trailing buffer bytes without a newline causes the subsequent
data: [DONE]\n\nframe to concatenate directly onto the previous chunk line (e.g.{"chunk": 1}data: [DONE]\n\n). This breaks Server-Sent Events line framing and causes client parsers to miss the completion signal.This change verifies whether
bytes(buffered)ends with\nbefore yielding it, appending a newline if omitted. This ensures strict SSE record separation across stream terminations. Normal already-delimited SSE chunks remain completely untouched.Validation
data: [DONE]merged into the trailing chunk without line demarcation.data: [DONE]\n\nstarts on its own record line.Overlap check
pixel_edge.py.routers/pixel.py.pixel_gateway.pixel_agent_teams.py.This PR addresses SSE framing boundary safety in
routers/pixel.pyand does not conflict with adjacent streaming changes.Risk / AI disclosure
AI-assisted defect analysis, implementation, and regression verification. This strengthens streaming frame protocol conformance and does not modify persistent files, models, or runtime routing logic. Independent human review remains a gate.
Follow-up integration evidence
Composed cleanly on top of #5569, #5871, and #5875 at HEAD without conflicts. Production and test diffs passed together; adjacent pixel-agent and pixel-settings checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.