fix(pixel-agent-teams): tolerate missing conversation in agent view - #5945
Open
vaibhavsrv wants to merge 1 commit into
Open
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_agent_teams.py,TeamManager.view(row)constructs the external sanitized presentation of team and agent records. When formatting agent review outcomes and retries, it iterates overagent['conversation']directly:If an agent record failed early during initialization (before conversation arrays were populated), was interrupted during serialization, or contains non-dict message entries, accessing
agent['conversation']throws an unhandledKeyErrororTypeError: 'NoneType' object is not iterable. This corrupts client status retrieval for the entire team.This change uses safe dictionary retrieval
conversation = agent.get("conversation") or []and verifiesisinstance(m, dict)before inspecting message roles. It also uses safe.get()methods across agent status, role, and retries attributes. Standard completed and failed agent views continue to render identically.Validation
TeamManager.view()on a team row with missing orNoneagent conversation failed withKeyError: 'conversation'/TypeError.Overlap check
TeamStore.list.roles_forinpixel_agent_teams.py.pixel_settings.This PR addresses internal dictionary access safety in
TeamManager.viewand does not conflict with concurrent PRs.Risk / AI disclosure
AI-assisted investigation, implementation, and regression test authoring. This hardens view projection safety and does not alter underlying data schemas, controller state machines, or network calls. Independent human review remains a gate.
Follow-up integration evidence
Composed cleanly on top of #5569, #5871, and #5875 at HEAD without conflicts. Production and test diffs passed together; adjacent pixel-agent and pixel-settings checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.