Repository navigation
fix(hf-artifact): parse hostname with optional port in resolve URLs - #5870
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/download-hf-artifact.py,parse_huggingface_resolve_url()validated the target endpoint by inspectingparsed.netloc.lower(). When a resolve URL contained an explicit standard port (e.g.https://huggingface.co:443/...) or credentials,parsed.netlocincluded the port suffix (e.g.huggingface.co:443), failing the hardcoded set check against{"huggingface.co", "www.huggingface.co", "hf.co"}and raising a false-positiveValueError: URL is not a Hugging Face URL.This patch normalizes host extraction using
(parsed.hostname or "").lower()and restricts permitted ports to standard HTTP/HTTPS ports (None,80,443), rejecting non-standard ports while permitting explicit port specifications.Validation
https://huggingface.co:443/unsloth/Llama-4-Scout-GGUF/resolve/main/model.gguftoparse_huggingface_resolve_url(); confirmed baseline raisedValueError: URL is not a Hugging Face URL.test_hf_download_helper.pypasses all 4 tests with exit code 0; valid URLs with:443parse correctly, and non-standard ports (:8443) are rejected.Overlap check
ods/installers/macos/with zero overlap in download helpers.ods/scripts/llm-cold-storage.sh.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens URL parsing and host/port validation in the artifact fallback downloader, not runtime network proxies. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5863 at 1de196a without conflicts. Production and test diffs passed together; artifact download and cache revision contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.