Repository navigation
fix(demo-offline): handle EOF cleanly during menu and pause prompts - #5869
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/demo-offline.sh, the interactive showcase menu and intermediatepausefunctions useread -r choiceandread -runderset -e. When executed in automated testing harnesses, piped streams, or headless environments where standard input is closed (</dev/null),readreturns a non-zero exit status on EOF. Becauseset -eis active, this unexpected return code abruptly terminates the script with exit code 1 instead of exiting cleanly with 0.This patch updates
pause()to allow non-zero returns (read -r || true) and modifies the menu loop to exit cleanly with code 0 upon encountering EOF onread -r choice.Validation
bash demo-offline.sh </dev/null; confirmed script aborted with exit code 1.test_demo_offline_eof.pypasses with exit code 0;demo-offline.shrenders header and exits 0 on EOF or explicit quit.Overlap check
ods/installers/macos/with zero overlap in demo scripts.ods/scripts/llm-cold-storage.sh.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens input EOF handling in the offline demonstration script, not runtime core services. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5861 at 2a24f49 without conflicts. Production and test diffs passed together; demo and showcase contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.