Repository navigation
fix(capability): declare associative arrays before service registry port fallback - #5865
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/build-capability-profile.sh, when the capability profiler runs without an activelib/service-registry.shfile, the script attempts to evaluate_LLM_PORT="${SERVICE_PORTS[llama-server]:-11434}". Becauseset -uis enabled andSERVICE_PORTShas not yet been declared as an associative array viadeclare -A, bash interprets the indexllama-serveras an arithmetic expression referencing an undeclared variablellama. This triggers a fatalllama: unbound variableerror and crashes hardware capability profiling during standalone or isolated CLI executions.This patch declares
SERVICE_PORTSandSERVICE_HEALTHas associative arrays prior to inspecting or sourcing the service registry, ensuring that string keys evaluate safely underset -ueven when the registry library is not loaded.Validation
build-capability-profile.shin an isolated directory withoutlib/service-registry.sh; confirmed bash exited with code 1 andllama: unbound variable.test_capability_unbound_ports.pypasses with exit code 0; capability profiling completes successfully, generatingcapabilities.jsonwith fallback port11434.Overlap check
ods/installers/macos/with zero overlap in capability scripts.ods/scripts/llm-cold-storage.sh.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens variable declarations in shell profiling utilities under strict mode, not runtime service admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5861 at 2a24f49 without conflicts. Production and test diffs passed together; capability and hardware classification checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.