Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/workflows/{id}/enable(and the workflow list availability flags) can never succeed for the shippedvoice-to-voiceworkflow.config/n8n/catalog.json) declares its dependencies as["whisper", "llama-server", "kokoro"].tts;kokorois only a declared alias (extensions/services/tts/manifest.yaml→aliases: [kokoro]).check_workflow_dependenciesresolved deps againstSERVICESkeys plus a single hardcoded legacy alias (ollama → llama-server).kokororesolved to nothing →results["kokoro"] = False→enableresponds400 Missing dependencies: kokoroeven while TTS runs healthy, and the workflow list marks it permanently unavailable.Why this matters
Enabling
voice-to-voicefails 100% of the time on a correct install, with an error message blaming a "missing" service that is actually running. Manifests have declared aliases for a while (kokoro,llm,workflows,webui,agent, …); any future workflow or feature check written against those names hits the same trap.Fix
config.py: expose the manifest'saliaseslist on eachSERVICESentry (additive field).routers/workflows.py:_service_aliases()builds the alias→id map fromSERVICES, andcheck_workflow_dependenciesresolves each dep through the legacy map first, then manifest aliases. Unknown deps still returnFalseunchanged.Tests
test_check_workflow_dependencies_manifest_alias:SERVICES["tts"] = {aliases: ["kokoro"]}+ healthy mock →result["kokoro"] is True, and the health probe is called with the resolved idtts. Fails onpublic-betabase (result["kokoro"]isFalse), passes here.test_check_workflow_dependencies_manifest_alias_unhealthy: same alias with adownservice →False(no false-positive availability).tests/test_workflows.py: 49/49 pass;py_compile+git diff --checkclean.Overlap check
Searched open PRs touching
routers/workflows.py,config.py,tests/test_workflows.py: #5644 (activation-failure reporting insideenable_workflow), #5672 (malformed catalog/executions tolerance), #5829/#5828 (inventory traversal, export), #5554 (exact-name matching), plus mechanical idioms PRs (#5485, #5567, #5571, #5575). This change is confined tocheck_workflow_dependenciesand one additiveservice_configfield — disjoint from all of them.